feat: dynamic lights - #3113
Merged
Merged
Conversation
Contributor
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below.
|
This was referenced Jan 13, 2025
…b to addressables
…o avoid being computed as TextureMove tweens.
# Conflicts: # Explorer/Assets/AddressableAssetsData/AssetGroups/Essentials.asset # Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportCategory.cs # Explorer/Assets/DCL/SDKComponents/Tween/Systems/TweenUpdaterSystem.cs # scripts/package-lock.json # scripts/package.json
AnsisMalins
suggested changes
Jan 27, 2025
…rt for protocol default values. Added support for shadow mask. Improved LightSource System architecture making it cleaner.
# Conflicts: # Explorer/Assets/AddressableAssetsData/AssetGroups/Essentials.asset # Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef # Explorer/Assets/DCL/RealmNavigation/Container/RealmNavigationContainer.cs.meta # Explorer/Assets/Protocol/DecentralandProtocol/LightSource.gen.cs.meta # Explorer/Assets/Protocol/DecentralandProtocol/SocialServiceV3.gen.cs.meta # scripts/package-lock.json # scripts/package.json
DafGreco
approved these changes
Feb 3, 2025
DafGreco
left a comment
There was a problem hiding this comment.
Lights checked on both platforms ! ✅
Windows check : ✅
03.02.2025_08.07.24_REC.mp4
Sanity check made on Windows :
- Chat interactions
- Skybox functionality
- Emotes
- Teleport ( Dollhouse , the inn and metadynelabs)
- Map
- Camera functionality
- Gallery
Macos check ✅
Sanity check made on macos :
- Backpack
- Emotes
- Teleport (Dollhouse, the inn , metadynelabs)
- Camera functionality
- Gallery
- Notifications
- Skybox functionality
AnsisMalins
approved these changes
Feb 3, 2025
# Conflicts: # Explorer/Assets/DCL/PerformanceAndDiagnostics/Diagnostics/ReportsHandling/ReportCategory.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Related PRs
Protocol PR: decentraland/protocol#234
SDK PR: decentraland/js-sdk-toolchain#1049
QA TEST STEPS
npm iand thennpm run startRedGreen cube
The cornell-boxes
DarkRoom
Hard shadow:

Soft shadow:

The Stage
Disclaimer: Some tooltips might have typos or might not get properly updated, that's a scene code bug not related to Dynamic Lights 😅