fix: Dynamic lights and Shared-Depencies as unity-package - #4289
Merged
Conversation
Contributor
dalkia
approved these changes
May 29, 2025
Ludmilafantaniella
self-requested a review
May 29, 2025 12:18
dalkia
self-requested a review
June 2, 2025 17:19
Contributor
|
I love this PR so much ❤️ bye bye submodules, we'll always remember you for things like the time you made our lives hell with git, or the time you blocked a merge, or the time your detached head was a pain to debug 👋👋👋 |
Ludmilafantaniella
approved these changes
Jun 2, 2025
Ludmilafantaniella
left a comment
Contributor
There was a problem hiding this comment.
✅ Verified and approved on both Windows and Mac!
I tested the dynamic lights in dalkia.dcl.eth and everything looks great — PROM lettering, tinting effects, spotlights, and shadow behaviors are all working as expected 🔦✨
Great job! 🙌
02.06.2025_17.38.35_REC.mp4
02.06.2025_17.36.49_REC.mp4
DALKIA.ESCENA.mp4
✅ Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:
- ✔️ Backpack and wearables in world
- ✔️ Emotes in world and in backpack
- ✔️ Teleport with map/coordinates/Jump In
- ✔️ Chat and multiplayer
- ✔️ Profile card
- ✔️ Camera
- ✔️ Skybox
dalkia
force-pushed
the
chore/updatesubmodules
branch
from
June 3, 2025 12:53
149d048 to
80900b6
Compare
AlejandroAlvarezMelucciDCL
approved these changes
Jun 3, 2025
AlejandroAlvarezMelucciDCL
left a comment
Contributor
There was a problem hiding this comment.
LGTM but out of curiosity left some questions 😊
NickKhalow
approved these changes
Jun 3, 2025
dalkia
enabled auto-merge (squash)
June 3, 2025 14:48
dalkia
disabled auto-merge
June 3, 2025 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unity-shared-dependenciesfrom submodule to unity-packageWe still ahve one TODO, that is to find the ebst way to build the asset bundle. Right now its not urgent since we dont expect
Scene.shaderchanges soon, but to improve the workflow we should address it. Right now, the asset bundles are manually built.Test steps
a. Check that you have a shinning word PROM on the ground

b. Check that you have a tinting color in this area

c. Check that you have a shinning effect in this area

d. Check that you see a spotlight in this area

dalkia.dcl.eth