Skip to content

fix: Dynamic lights and Shared-Depencies as unity-package - #4289

Merged
dalkia merged 12 commits into
release/2025-06-03from
chore/updatesubmodules
Jun 3, 2025
Merged

fix: Dynamic lights and Shared-Depencies as unity-package#4289
dalkia merged 12 commits into
release/2025-06-03from
chore/updatesubmodules

Conversation

@GBirch33

@GBirch33 GBirch33 commented May 29, 2025

Copy link
Copy Markdown
Contributor
  • Moves unity-shared-dependencies from submodule to unity-package
  • Rebuilds the asset bundles locally.
  • Remove the build action on every new cloud build. We need to find the best way to do it with the new unity-package approach
  • Fixes the dynamic lights ([QA] SDK Lights | New lights animation are broken #4036)

We still ahve one TODO, that is to find the ebst way to build the asset bundle. Right now its not urgent since we dont expect Scene.shader changes soon, but to improve the workflow we should address it. Right now, the asset bundles are manually built.

Test steps

  1. In the MVFW scene,

a. Check that you have a shinning word PROM on the ground
image

b. Check that you have a tinting color in this area
image

c. Check that you have a shinning effect in this area
image

d. Check that you see a spotlight in this area
image

  1. Retest this whole PR. For convenience, the scene has been deployed in dalkia.dcl.eth

@GBirch33
GBirch33 requested review from a team as code owners May 29, 2025 11:14
@github-actions
github-actions Bot requested review from DafGreco, dalkia and pravusjif May 29, 2025 11:14
@github-actions

github-actions Bot commented May 29, 2025

Copy link
Copy Markdown
Contributor

badge

New build in progress, come back later!

@Ludmilafantaniella
Ludmilafantaniella self-requested a review May 29, 2025 12:18
@dalkia dalkia changed the title chore: Update Shared Deps Submodule for diversion to package approach fix: Dynamic lights and Shared-Depencies as unity-package Jun 2, 2025
@dalkia
dalkia self-requested a review June 2, 2025 17:19
@AlejandroAlvarezMelucciDCL

Copy link
Copy Markdown
Contributor

I love this PR so much ❤️ bye bye submodules, we'll always remember you for things like the time you made our lives hell with git, or the time you blocked a merge, or the time your detached head was a pain to debug 👋👋👋

@Ludmilafantaniella Ludmilafantaniella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified and approved on both Windows and Mac!
I tested the dynamic lights in dalkia.dcl.eth and everything looks great — PROM lettering, tinting effects, spotlights, and shadow behaviors are all working as expected 🔦✨
Great job! 🙌

02.06.2025_17.38.35_REC.mp4
02.06.2025_17.36.49_REC.mp4
DALKIA.ESCENA.mp4

✅ Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • ✔️ Backpack and wearables in world
  • ✔️ Emotes in world and in backpack
  • ✔️ Teleport with map/coordinates/Jump In
  • ✔️ Chat and multiplayer
  • ✔️ Profile card
  • ✔️ Camera
  • ✔️ Skybox

@dalkia
dalkia force-pushed the chore/updatesubmodules branch from 149d048 to 80900b6 Compare June 3, 2025 12:53
@dalkia dalkia added the clean-build Used to trigger clean build on PR label Jun 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but out of curiosity left some questions 😊

Comment thread Explorer/Assets/Editor/CloudBuild.cs
@dalkia
dalkia enabled auto-merge (squash) June 3, 2025 14:48
@dalkia
dalkia disabled auto-merge June 3, 2025 15:41
@dalkia
dalkia changed the base branch from dev to release/2025-06-03 June 3, 2025 15:41

@mihakrajnc mihakrajnc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

B-E-A-UTIFUL!

@dalkia
dalkia merged commit 600089e into release/2025-06-03 Jun 3, 2025
@dalkia
dalkia deleted the chore/updatesubmodules branch June 3, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean-build Used to trigger clean build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants