Repository navigation
feat(triage): make labels off by default (CL-12165) - #852
Merged
Merged
Conversation
Contributor
|
Merged before Triage finished on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Triage now adds no labels unless the policy file sets
labels: trueor a map that renames them. A policy withoutlabels:, or no policy file, means no verdict labels and no Triage: Failed to Run.labelskey reads as off; a repository's own key still wins overextends.labels: true, so the labels survive the round trip.labels: true, and its label section and Failed to Run text are trimmed to match. The setup skill's reference is updated too.Verification
bun run checkandbun run lintpass.bun --conditions=intx-src test packages/triage-contracts packages/triage-workflows packages/triage-manager packages/github-tool tests/model tests/policy-corpus: 544 pass.bun --conditions=intx-src test --parallel=2 tests/chain: 13 pass. The chain policies setlabels: true.labels: true(on) and a rename map (on), checked against the policy the hub runs.Closes CL-12165