Repository navigation
fix(triage): strip Triage's labels when a pull request closes before its verdict (CL-12164) - #855
Merged
Merged
Conversation
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
Approve held: code review has 1 finding at P2 or above open on this head. |
…its verdict (CL-12164)
TheGreatAxios
force-pushed
the
fix-close-strips-labels
branch
from
November 5, 2026 04:05
215251c to
4e2bd3c
Compare
TheGreatAxios
changed the title
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
…the comment (CL-12164)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On GitHub, a pull request that closes or merges before its verdict now loses Triage's retired labels (such as "Triage: Waiting for CI") even where Triage does not comment, provided the workspace lets Triage post there. Before this change, with comments off, nothing was written and an old label stayed. Without the comment, a current verdict cannot be told from a stale one, so current verdict labels and Failed to Run stay. With the comment on, all of Triage's own labels come off unless the comment shows a verdict on the head, whether or not the workspace grants labels, matching how #852 clears Triage's leftover labels once labels are off. Removing the labels reuses the mirror's existing stripping, and no label is added.
The User Manual and the
closeOutandclosedOutdescriptions now say this.Verification
bun run check,bun run lint,bun --conditions=intx-src test ./packages/triage-workflows ./tests/model(179 pass).Refs CL-12164