Skip to content

ci: run each suite on a pull request only when it touches what the suite covers - #838

Merged
TheGreatAxios merged 1 commit into
mainfrom
cl-12132-run-suites-by-path
Nov 4, 2026
Merged

TheGreatAxios merged 1 commit into
mainfrom
cl-12132-run-suites-by-path

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Contributor

Summary

  • On a pull request, typecheck and each test suite run only when the change touches what they cover: unit for the hub, web or shared code, Postgres for the hub or shared code, dom for the web app. Shared code is packages, vendor, tooling, tests, the lockfile and CI itself, and runs everything. A change of only Markdown runs lint alone.
  • Each job still reports, as chain's do, so the required checks pass; only its steps are skipped. Merge queue runs keep running everything.

Verification

Refs CL-12132

@linear-code

linear-code Bot commented Nov 4, 2026

Copy link
Copy Markdown

CL-12132

@corbits-triage

corbits-triage Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Triage: Pass

No changes needed from you. A maintainer will review this pull request.

Notes:

  • changes sensitive paths: ci: .github/workflows/ci.yml
  • Risk: medium (ci paths)

Approve held: code review has 1 finding at P2 or above open on this head.

Comment thread .github/workflows/ci.yml
Comment on lines +98 to +106
shared:
- 'packages/**'
- 'vendor/**'
- 'tooling/**'
- 'tests/**'
- 'bun.lock'
- 'package.json'
- 'tsconfig*.json'
- '.github/**'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 · Unit tests read skills/ Markdown, but no filter covers skills/

packages/triage-contracts/src/setup-skill.test.ts is part of the unit suite. It reads skills/corbits-triage-setup/reference.md and checks its yaml blocks against the starter policy. skills/** is not in the shared, hub or web filters. The new code filter also ignores *.md files. So on a PR, a change under skills/ never triggers the unit suite, and a broken reference.md can pass PR CI without the test that guards it.

A PR that edits only skills/corbits-triage-setup/reference.md and breaks a yaml example: unit is skipped and the PR shows green.

Resolve this comment. Triage will not finish while it is open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant