Repository navigation
ci: run each suite on a pull request only when it touches what the suite covers - #838
Conversation
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
Approve held: code review has 1 finding at P2 or above open on this head. |
| shared: | ||
| - 'packages/**' | ||
| - 'vendor/**' | ||
| - 'tooling/**' | ||
| - 'tests/**' | ||
| - 'bun.lock' | ||
| - 'package.json' | ||
| - 'tsconfig*.json' | ||
| - '.github/**' |
There was a problem hiding this comment.
P2 · Unit tests read skills/ Markdown, but no filter covers skills/
packages/triage-contracts/src/setup-skill.test.ts is part of the unit suite. It reads skills/corbits-triage-setup/reference.md and checks its yaml blocks against the starter policy. skills/** is not in the shared, hub or web filters. The new code filter also ignores *.md files. So on a PR, a change under skills/ never triggers the unit suite, and a broken reference.md can pass PR CI without the test that guards it.
A PR that edits only skills/corbits-triage-setup/reference.md and breaks a yaml example: unit is skipped and the PR shows green.
Resolve this comment. Triage will not finish while it is open.
Summary
Verification
Refs CL-12132