Repository navigation
ci: run chain and dom only in the merge queue, and close two path-filter holes (CL-12132) - #849
Closed
TheGreatAxios wants to merge 1 commit into
Closed
TheGreatAxios wants to merge 1 commit into
TheGreatAxios wants to merge 1 commit into
Conversation
…ter holes (CL-12132)
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
|
Contributor
Author
|
Closing: #838 already runs chain and dom only when a PR touches what they cover, so they keep catching bugs before merge. Running them only in the merge queue would move those catches to merge time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pull requests now run changes, lint, typecheck, policy and the unit and postgres tests. The chain shards and the dom tests still report on a pull request so their required checks pass, but their steps run only in the merge queue. Push behaviour is unchanged.
skills/**is now in thesharedfilter, because a contracts test reads the setup skill's reference.Dockerfile,apps/*/Dockerfile*,bun.lockor.github/workflows/**change. This reusesimage.yml, which pushes only on a push to main.platformfilter is removed.Verification
bunx --bun yaml-lint .github/workflows/ci.ymlandbun run lintpass.test (dom)succeeding with their steps skipped.Refs CL-12132