Skip to content

test: pair the CNCFProjectCard fixture card with a since-only card - #1124

Merged
mrbobbytables merged 1 commit into
mainfrom
quality/test-cncf-project-card-mixed-meta
Oct 7, 2026
Merged

mrbobbytables merged 1 commit into
mainfrom
quality/test-cncf-project-card-mixed-meta

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Pairs the end-to-end coverage fixture page's version-only <CNCFProjectCard>
with a second card carrying since and no version, and asserts both.

src/components/CNCFProjectCard/index.js:29 guards the meta row on
(since || version). The right-hand operand is the file's one uncovered
end-to-end region, and opening more architecture pages cannot reach it.
Docusaurus gives each docs page its own bundle chunk, so the browser reports an
independent set of V8 ranges per page, and V8 emits a range for version only
when that range's count differs from the count of the surrounding render. Every
page that renders the component is uniform in since — adobe.md,
allianz.md, flipkart-chaos-engineering.md, both swisscom pages and
zeiss.md give every card a since, so version is never evaluated and each
chunk reports the operand zero; cern-scientific-computing.md, colopl.md and
the existing fixture page give no card a since, so version is always
evaluated and no range is emitted for it at all.

Rendering both shapes on one page evaluates the operand for one card and not
the other, which is the arrangement that reports it reached. The third test
pins that the two cards stay on the same page, because splitting them would
silently restore the uniform shape and the coverage with it.

This is not the region-attribution problem of #1066 / #1079: every region here
comes from the real build, the coordinates already agree, and the union is
behaving correctly.

Measurements

Reproduced locally at main 7ab301e — npm run build:e2e:coverage, then
npm run test:e2e:coverage with E2E_COVERAGE_DIR/E2E_COVERAGE_RUN_ID set,
then npm run report:e2e:coverage -- --input <run> --build build:

CNCFProjectCard regions src files regions
before (7ab301e, 324 passed) 93.75% — uncovered 29 91.41% (415/454)
after (this branch, 326 passed) 100.00% — none 91.52% (421/460)

The before-figures match the published CI artifact e2e-coverage, id
11406607319, from run
37450408805:
{"file":"src/components/CNCFProjectCard/index.js","regions":16,"coveredRegions":15,"regionPercent":93.75,"uncoveredRegions":[29]}.

npm run check and npm run test:unit (1966 passed) are green on this branch.

Coordination

Touches tests/e2e/fixtures/docs/cncf-project-card.mdx and
tests/e2e/cncf-project-card.spec.js only. Neither appears in any open
hold-gated PR: #1114 touches tests/e2e-coverage-report.test.mjs, #1110 the
data-overlay mechanism, and #1104 / #1113 / #1117 / #1120 are scoped to
DirectoryFreshness, GroupLinkStatus, MetricsDashboard and the profile
lightboxes. No data/*.json overlay is involved, so
tests/e2e-data-fixtures.test.mjs and tests/e2e/data-variants.spec.js are
untouched, and no workflow file is edited.

Related Issue

Closes #1123

— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88

The right-hand operand of the (since || version) meta guard in
src/components/CNCFProjectCard/index.js:29 is never reported as reached by
the end-to-end run. Docusaurus gives each docs page its own chunk and V8
emits a range for that operand only when its count differs from the count of
the surrounding render, and every page rendering the component is uniform in
'since': adobe, allianz, flipkart, both swisscom pages and zeiss give every
card a since, so the operand is never evaluated and each chunk reports it
zero; cern, colopl and the existing fixture page give no card a since, so it
is always evaluated and no range is emitted at all.

Rendering both shapes on the fixture page evaluates the operand for one card
and not the other, which is the arrangement that reports it reached.

Closes #1123

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: quality <quality@hive.kubestellar.io>
@hivecommons-hive hivecommons-hive Bot added the hold label Oct 6, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human review by the hive's ACMM level gate.

This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the outreach agent is always held because it publishes project-facing communication.

Hive will keep the hold label until a human removes it. Operators can make a deliberate one-off release during an ACMM level change with release_level_holds=true, but level changes never release this hold automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] CNCFProjectCard's version operand is unreachable end-to-end because every page that renders the component is uniform in since

1 participant