Repository navigation
test: pair the CNCFProjectCard fixture card with a since-only card - #1124
Merged
Merged
Conversation
The right-hand operand of the (since || version) meta guard in src/components/CNCFProjectCard/index.js:29 is never reported as reached by the end-to-end run. Docusaurus gives each docs page its own chunk and V8 emits a range for that operand only when its count differs from the count of the surrounding render, and every page rendering the component is uniform in 'since': adobe, allianz, flipkart, both swisscom pages and zeiss give every card a since, so the operand is never evaluated and each chunk reports it zero; cern, colopl and the existing fixture page give no card a since, so it is always evaluated and no range is emitted at all. Rendering both shapes on the fixture page evaluates the operand for one card and not the other, which is the arrangement that reports it reached. Closes #1123 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
This was referenced Oct 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Pairs the end-to-end coverage fixture page's
version-only<CNCFProjectCard>with a second card carrying
sinceand noversion, and asserts both.src/components/CNCFProjectCard/index.js:29guards the meta row on(since || version). The right-hand operand is the file's one uncoveredend-to-end region, and opening more architecture pages cannot reach it.
Docusaurus gives each docs page its own bundle chunk, so the browser reports an
independent set of V8 ranges per page, and V8 emits a range for
versiononlywhen that range's count differs from the count of the surrounding render. Every
page that renders the component is uniform in
since—adobe.md,allianz.md,flipkart-chaos-engineering.md, both swisscom pages andzeiss.mdgive every card asince, soversionis never evaluated and eachchunk reports the operand zero;
cern-scientific-computing.md,colopl.mdandthe existing fixture page give no card a
since, soversionis alwaysevaluated and no range is emitted for it at all.
Rendering both shapes on one page evaluates the operand for one card and not
the other, which is the arrangement that reports it reached. The third test
pins that the two cards stay on the same page, because splitting them would
silently restore the uniform shape and the coverage with it.
This is not the region-attribution problem of #1066 / #1079: every region here
comes from the real build, the coordinates already agree, and the union is
behaving correctly.
Measurements
Reproduced locally at
main7ab301e—npm run build:e2e:coverage, thennpm run test:e2e:coveragewithE2E_COVERAGE_DIR/E2E_COVERAGE_RUN_IDset,then
npm run report:e2e:coverage -- --input <run> --build build:src filesregions7ab301e, 324 passed)29The before-figures match the published CI artifact
e2e-coverage, id11406607319, from run37450408805:
{"file":"src/components/CNCFProjectCard/index.js","regions":16,"coveredRegions":15,"regionPercent":93.75,"uncoveredRegions":[29]}.npm run checkandnpm run test:unit(1966 passed) are green on this branch.Coordination
Touches
tests/e2e/fixtures/docs/cncf-project-card.mdxandtests/e2e/cncf-project-card.spec.jsonly. Neither appears in any openhold-gated PR: #1114 touches
tests/e2e-coverage-report.test.mjs, #1110 thedata-overlay mechanism, and #1104 / #1113 / #1117 / #1120 are scoped to
DirectoryFreshness,GroupLinkStatus,MetricsDashboardand the profilelightboxes. No
data/*.jsonoverlay is involved, sotests/e2e-data-fixtures.test.mjsandtests/e2e/data-variants.spec.jsareuntouched, and no workflow file is edited.
Related Issue
Closes #1123
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88