Repository navigation
test: correct root-docs-links' account of what check:links does - #1138
Merged
Merged
Conversation
tests/root-docs-links.test.mjs stated that `npm run check:links` "delegates to a Makefile that does not exist". That is false at 7ab301e: package.json:10 shells out to markdown-link-check with .markdown-link-check.json, there is no Makefile in the repository, and tests/markdown-link-check-config.test.mjs guards that config against a devDependency bump silently dropping a key. The real limitation is different and is the one a reader needs: the command works, but no workflow invokes it, and it checks outbound http(s) URLs rather than the relative paths these cases resolve on disk. Signed-off-by: quality <quality@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will keep the |
This was referenced Oct 7, 2026
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Corrects a factually wrong comment in
tests/root-docs-links.test.mjs. It iscomment-only: no case, assertion or helper changes, and the file's 7 cases stay
green (
npm run test:unit -- tests/root-docs-links.test.mjs: 7 pass, 0 fail).The file said, at line 10:
Measured at
main=7ab301e:package.json:10defines_check:links-mdas a loop over root*.mdcalling
npx markdown-link-check --config .markdown-link-check.json. Thereis no
makeinvocation anywhere inpackage.json.ls Makefile→ no such file, and no source file in the repository mentionsone.
.markdown-link-check.jsonis actively guarded bytests/markdown-link-check-config.test.mjs, which derives the honoured keyset from the installed CLI so a devDependency bump cannot silently disable a
setting.
So
check:linksis not vestigial, and a reader of this test was being told itwas. The replacement states the two things that are actually true and that
explain why these offline cases exist: no workflow invokes
check:links(the subject of #1137), and it checks outbound
http(s)URLs rather than therelative on-disk paths these cases resolve — the complementary half, not the
same check.
Related Issue
Refs #1137 (needs-human: #1137's first box adds a scheduled
link-checkjob to.github/workflows/ci.yml, which this agent's contributor-tier token cannotpush — GitHub rejects any diff touching
.github/workflows/**without theworkflowspermission. This PR lands only the second box. The exact YAML forthe first is in the issue body.)
Coordination
Touches exactly one file,
tests/root-docs-links.test.mjs, which no open PRmodifies: #1090 (
scripts/lib/svg-active-content.mjs), #1112 (package.json,package-lock.json), #1122 (scripts/lib/mdx-active-content.mjs), #1104,#1110, #1113, #1114, #1117, #1120, #1124, #1126, #1128, #1130, #1133 and #1136
were each checked with
gh pr view --json filesand none names this path. Itis also disjoint from #1137's workflow half, from the
tests/tools/**coveragecluster (#1128, #1130, #1131) and from the e2e region-attribution cluster
(#1066, #1079, #1097).
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-opus-5 copilot=1.0.88