Repository navigation
#235 - LoginThrottlingTest: do not assert the number of minutes of the throttling message - #236
Closed
njoubert-cleverage wants to merge 1 commit into
Closed
njoubert-cleverage wants to merge 1 commit into
njoubert-cleverage wants to merge 1 commit into
Conversation
…e only, the number of minutes is computed by Symfony Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Included in #239: each PR failed a required check fixed by the other (Rector here, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #235.
The weekly build fails on every
highestjob since the Symfony releases of late October 2026: the throttling message of the login form is now... please try again in 2 minutes.instead of1 minute.. This number is computed by Symfony'sLoginThrottlingListenerfrom the limiter of the firewall, not by the bundle. The tests now assert the start of the message only (the request is throttled), as the bundle does not control the number of minutes.Test only: no CHANGELOG entry.
Note: the weekly Quality job fails too (new
EventSubscriberToAttributeRectorrule onProcessEventSubscriberand 2 other files), not fixed here.Requirements
Breaking changes
None.
🤖 Generated with Claude Code