Repository navigation
#234 - Notifications: a process stopped by a StopTask with reported log levels triggers finish_with_report - #237
Merged
Merged
Conversation
… in its report as finish_with_report Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
njoubert-cleverage
force-pushed
the
234
branch
from
November 2, 2026 13:31
aca831b to
fa61210
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #234.
Change of 3.4 (#220): a process stopped on purpose by a
StopTaskgets thestoppedstatus, not notified by default, while it ended asfinish_with_report(notified by default) before 3.4 when it had logged warnings or errors.NotificationTrigger::fromProcessExecution(): astoppedexecution with log levels counted in its report triggersfinish_with_report(importancemedium, notified by default). Without such log levels, it still triggersstopped.ProcessExecution::isStopRequested()) still triggersstopped: it ends with a process failure, logged asCriticaland counted in the report, which would otherwise notify every stop from the UI.Status: stopped.UPGRADE.md(newv3.4.1section:stoppedcan be removed from the notified statuses if it was added for 3.4),09-notifications.mdand01-bundle_configuration.md(also fixes thestatusesdescription, which said "stopped from the UI" only).CI: the
highesttest jobs fail onmainbecause of an unrelated test (#235, fixed by #236), and the Quality job because of a new Rector rule.Requirements
Breaking changes
None: the stops with reported log levels are notified again by default, as before 3.4.
🤖 Generated with Claude Code