Skip to content

feat(web): shared PR label, media tile, and api-client pieces for Files - #1070

Merged
Zach Dunn (zachdunn) merged 9 commits into
mainfrom
claude/files-web-shared
Oct 5, 2026
Merged

Zach Dunn (zachdunn) merged 9 commits into
mainfrom
claude/files-web-shared

Conversation

@zachdunn

Copy link
Copy Markdown
Member

Stacked on #1069; review and merge that first. Slice 2 of 5 for the Files, Links and Storage tabs: shared web pieces only. No new pages.

What changes

  • PrLabel: one PR/issue label, rendered as #123 Title with a status dot. When the title is unknown it falls back to owner/repo #123.

    • prLabelParts (pure) in packages/ui/src/lib/pr-label.ts.
    • A React PrLabel in packages/ui.
    • A no-JS HTML/Astro version for server-rendered and public pages.
    • Screen readers hear the kind and state, e.g. "(pull request, open)".
    • Links only accept https://… or root-relative paths.
  • Where it now appears:

    • the right-rail connected work list
    • Screenshots tile badges and the hover card
    • the Files metadata chips and the single-PR banner

    Link targets are unchanged. Captions that showed before still show, including "PR test: scratch PR for uploads E2E (will be closed) #7" when only the number is known.

  • Media tiles: mediaTileView (pure) decides how a file renders: image, video, poster, locked, missing, or extension fallback. The public /c/ page now renders through it, with no visual change and no framework JS. A React MediaTile is added for the Files views in slice 4, but nothing mounts it yet.

  • File types: shotKindFromKey now delegates to fileTypeClassFromKey from @uploads/comment-render/scope, so the web app and the API sort files into types the same way.

  • API client: new calls for slice 1's endpoints:

    • fetchPulls, fetchRepos and fetchScopeFiles
    • listWorkspaceFeeds, createWorkspaceFeed and deleteWorkspaceFeed

    Each returns an ApiResult<T> and takes optional SessionOpts, so pages can call them during server rendering. Responses are parsed in scope-parsers.ts.

Testing

  • pnpm test, the web typecheck (astro check) and pnpm check pass.
  • Unit tests cover:
    • prLabelParts, prLabelSrText and the href guard
    • mediaTileView
    • the label fallbacks on Screenshots and Files
    • the api-client calls, using fake fetch for the 409 limit, 404 and 400 cases
  • A render test covers the React PrLabel.
  • /c/ was compared before and after on the local stack: the markup is byte-identical for real data.

@changeset-bot

changeset-bot Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bef581b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed) (1)
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e093e071-4888-4090-8149-27de913217e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
uploads-api bef581b Commit Preview URL

Branch Preview URL
Oct 04 2026, 11:42 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
uploads-auth bef581b Oct 04 2026, 11:42 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
uploads-web bef581b Commit Preview URL

Branch Preview URL
Oct 04 2026, 11:43 PM

@zachdunn
Zach Dunn (zachdunn) added this pull request to stack #1071 October 4, 2026 22:29
Base automatically changed from claude/change-feeds-web-ui-37caca to main October 4, 2026 23:41
@zachdunn
Zach Dunn (zachdunn) merged commit 96cd9e5 into main Oct 5, 2026
6 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/files-web-shared branch October 5, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant