Skip to content

Files and live links: small follow-ups from the redesign #1088

Description

@zachdunn

Small gaps left from the Files, Links, and Storage redesign (#1069, #1070, #1073, #1078, #1080). Each is independent; fix in any order.

  • Repo filter lists only 20 repos. The Repo select on Files > By pull request reads the first page of GET /v1/workspaces/:ws/repos, so a workspace with more repos cannot pick the rest. That call also builds thumbnails it does not use. Fix: a lightweight repo-name list (no thumbnails), or page through /repos.
  • Public item endpoint missing from the API docs. GET /public/feeds/{id}/items/{item} is not in apps/web/public/.well-known/openapi.json or docs/api.md, and openapi-contract.test.ts only scopes /public/feeds/:id. Fix: document it and add it to the contract test's public paths.
  • Live link pager stops at 2,000 files without saying so. The item pager scans at most 2,000 scope rows (SCOPE_SCAN_CAP). Items past that return 404 on /c/<id>/<item>, and total reads as the cap. Fix: say so on the page ("2,000+") and decide what an item past the cap should show.
  • PR label does not name its kind for screen readers. PrLabel (@uploads/ui) renders as a plain span when it has no link, and its compact variant drops the title, so a screen reader hears a number without "pull request" or "issue". Fix: visually hidden kind text in both cases.
  • /pulls runs independent reads one after another. Title resolution, the rollup backfill, thumbnails, and the storage config load wait on each other. Fix: run thumbnails and the storage config alongside title resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions