Skip to content

fix: sharing different URLs for presenter and viewers always fails as malformed #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuiLeme merged 1 commit into from
Oct 30, 2026
Merged

fix: sharing different URLs for presenter and viewers always fails as malformed #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/components/modal-to-share-link/link-form/text-input/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ export function TextInputComponent(props: TextInputComponentProps) {
} else {
label = 'Presenter URL: ';
}
// Each input needs its own name and id: the submit handler reads them by name
// (`link` and `viewerLink`), and a shared name would turn `form.link` into a list
const inputName = isViewer ? 'viewerLink' : 'link';
const inputId = isViewer ? 'viewer-link-receiver' : 'link-receiver';

const styleOfLabelInPreviewMode: React.CSSProperties = !isUrlSameForRole
? { marginBottom: '1rem' }
: null;
Expand All @@ -37,17 +42,17 @@ export function TextInputComponent(props: TextInputComponentProps) {
<Styled.FormToSendUrlItem
style={styleOfLabelInPreviewMode}
as="label"
htmlFor="link-receiver"
htmlFor={inputId}
>
<Styled.LabelForm>
{label}
</Styled.LabelForm>
<div style={styleOfPreviewButtonWrapper}>
<Styled.LabelFormTextInput
id="link-receiver"
id={inputId}
value={url}
type="text"
name="link"
name={inputName}
placeholder="https://..."
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
setPreviousModalState((p) => {
Expand Down
Loading