Repository navigation
fix: sharing different URLs for presenter and viewers always fails as malformed - #40
Merged
GuiLeme merged 1 commit intoOct 30, 2026
Conversation
… malformed Both URL inputs were rendered with name="link" and the same id, so with "Same URL for presenter and viewers" unchecked the submit handler read form.link as a RadioNodeList (empty value) and form.viewerLink as undefined, rejecting every link. Give each input its own name and id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GtQ5Bqwqnjb3mwv6RirFmg
GuiLeme
approved these changes
Oct 30, 2026
GuiLeme
left a comment
GuiLeme
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Note for future evaluations of this PR: this PR alone doesn't work for the viewer, I had to merge upstream/v0.1.x into this branch to make it work (what probably fixed it was the recent changes to make the Generic link more reactive - #38).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes sharing different URLs for the presenter and the viewers.
Both URL inputs in the share modal were rendered with
name="link"andid="link-receiver". With "Same URL for presenter and viewers" unchecked,handleSendLinkToIframereadsform.link(aRadioNodeListwhosevalueis''when it holds text inputs) andform.viewerLink(which did not exist), so every submission failed with "Link is malformed, please insert a valid one".How to reproduce
https://pt.wikipedia.org) and, optionally, "Viewer URL" with another one (e.g.https://es.wikipedia.org).Expected: the presenter sees the presenter URL and the viewers see the viewer URL.
Actual: the modal shows "Error: Link is malformed, please insert a valid one" and nothing is shared, whatever URLs are typed.
Fix
Each input now gets its own
name(link/viewerLink, the names the submit handler already expects) and its ownid. The duplicatedidalso made the viewer URL label focus the presenter URL input; that is fixed as well.Closes Issue(s)
Closes #
Motivation
Only the "same URL for everyone" mode was usable; the presenter/viewer URL split was broken.