Skip to content

feat(types): add the speedbump order status and update events #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
extremeandy wants to merge 1 commit into
base: claude/unknown-string-enum-fallback-1e103a
Choose a base branch
from
+30 −0
Open

feat(types): add the speedbump order status and update events #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions types/src/order.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ pub enum OrderStatus {
TriggerPending,
/// The trigger order failed to trigger.
TriggerFailed,
/// The engine accepted the order and will release it after the speedbump.
PendingRelease,
/// A status this client version does not know. Carries the wire string.
#[strum(default)]
Unknown(String),
Expand Down Expand Up @@ -365,6 +367,10 @@ pub enum OrderUpdateType {
OrderModified,
TriggerPlaced,
TriggerFailed,
/// The order was accepted and is held behind the speedbump.
Speedbumped,
/// The order was expired while held behind the speedbump.
ReleaseFailed,
/// An event type this client version does not know. Carries the wire string.
#[strum(default)]
Unknown(String),
Expand Down Expand Up @@ -539,6 +545,7 @@ mod tests {
fn order_status_wire() {
assert_wire(&OrderStatus::PartiallyFilled, "PartiallyFilled");
assert_wire(&OrderStatus::TriggerFailed, "TriggerFailed");
assert_wire(&OrderStatus::PendingRelease, "PendingRelease");
assert_wire(
&OrderStatus::Unknown("SomeFutureStatus".into()),
"SomeFutureStatus",
Expand All @@ -560,6 +567,8 @@ mod tests {
#[test]
fn order_update_type_wire() {
assert_wire(&OrderUpdateType::TriggerPlaced, "triggerPlaced");
assert_wire(&OrderUpdateType::Speedbumped, "speedbumped");
assert_wire(&OrderUpdateType::ReleaseFailed, "releaseFailed");
assert_wire(
&OrderUpdateType::Unknown("someFutureEvent".into()),
"someFutureEvent",
Expand Down Expand Up @@ -609,6 +618,27 @@ mod tests {
assert_eq!(trigger_by_index_str, "\"IndexPrice\"");
}

#[test]
fn test_order_update_speedbump() {
let data = r#"
{"E":1748288615134547,"O":"USER","Q":"3568.3445","S":"Ask","T":1748288615133255,"V":"RejectTaker","X":"PendingRelease","Z":"0","e":"speedbumped","f":"GTC","i":"114575842681290753","o":"LIMIT","p":"178.15","q":"20.03","r":false,"s":"SOL_USDC","t":null,"z":"0"}
"#;
let order_update: OrderUpdate = serde_json::from_str(data).unwrap();
assert_eq!(order_update.event_type, OrderUpdateType::Speedbumped);
assert_eq!(order_update.order_status, OrderStatus::PendingRelease);

let data = r#"
{"E":1748288615134547,"O":"USER","Q":"3568.3445","R":"OrderBookClosed","S":"Ask","T":1748288615133255,"V":"RejectTaker","X":"Expired","Z":"0","e":"releaseFailed","f":"GTC","i":"114575842681290753","o":"LIMIT","p":"178.15","q":"20.03","r":false,"s":"SOL_USDC","t":null,"z":"0"}
"#;
let order_update: OrderUpdate = serde_json::from_str(data).unwrap();
assert_eq!(order_update.event_type, OrderUpdateType::ReleaseFailed);
assert_eq!(order_update.order_status, OrderStatus::Expired);
assert_eq!(
order_update.order_expiry_reason.as_deref(),
Some("OrderBookClosed")
);
}

#[test]
fn test_order_update_trigger_failed_and_unknown() {
let data = r#"
Expand Down