feat(types): add the speedbump order status and update events - #125
Open
extremeandy wants to merge 1 commit into
Open
extremeandy wants to merge 1 commit into
extremeandy wants to merge 1 commit into
Conversation
OrderStatus gains `PendingRelease`; OrderUpdateType gains `Speedbumped` and `ReleaseFailed` (wire values `speedbumped` / `releaseFailed`). These are the values the exchange emits for an order held in the taker speedbump window. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the wire values the taker speedbump introduces:
OrderStatus::PendingRelease(PendingRelease)OrderUpdateType::Speedbumped(speedbumped)OrderUpdateType::ReleaseFailed(releaseFailed)speedbumpedmirrorstriggerPlaced: the order was accepted and is held for the speedbump delay.releaseFailedmirrorstriggerFailed: the held order could not be released and arrives inExpiredstatus with an expiry reason. The expiry reason and API error code fields on this client are plain strings, so the new reasons (OrderBookClosed,CancelOnlyMode,Maintenance, and others) and the newORDER_PENDING_RELEASEerror code need no further change here.Message-level tests cover a
speedbumpedupdate carryingPendingReleaseand areleaseFailedupdate carrying an expiry reason.Until this lands, clients on #119 parse these values into
Unknown("PendingRelease")/Unknown("speedbumped")rather than failing.Test plan
just checkjust test🤖 Generated with Claude Code