Skip to content

[electrophysiology_browser] Factorize recording panel and improve typing - #10734

Open
MaximeBICMTL wants to merge 9 commits into
aces:29.0-releasefrom
MaximeBICMTL:ephys-recording-panel-refactor-main
Open

[electrophysiology_browser] Factorize recording panel and improve typing#10734
MaximeBICMTL wants to merge 9 commits into
aces:29.0-releasefrom
MaximeBICMTL:ephys-recording-panel-refactor-main

Conversation

@MaximeBICMTL

@MaximeBICMTL MaximeBICMTL commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Upstream of some changes from my MEG/MEEGqc branch so that it does not diverge too much from main.

Summary

This PR mostly moves code around and converts untyped class unfactorized components into typed functional dedicated components:

  • Extract top-level recording component from session view into a typed functional RecordingSection component.
  • Extract file details into a typed functional DetailsPanel component.
  • Convert DownloadPanel and SummaryPanel into a typed functional component.
  • Convert Sidebar and SidebarContent into a single typed functional component (the CSS is still rather dubious though).
  • Change UI to use titles sections rather than nested panels (which take a lot of space and are visually ugly IMO).

Link with other PRs

This PR touches files also touched by two other PR:

The conflicts are rather simple, I will rebase this PR as needed if/when those are merged in main.

Showcase

2026-07-02.17-39-54.mp4

@github-actions github-actions Bot added Language: Javascript PR or issue that update Javascript code Module: electrophysiology_browser PR or issue related to electrophysiology_browser module labels Jul 2, 2026
@MaximeBICMTL MaximeBICMTL added the Category: Refactor PR or issue that aims to improve the existing code label Jul 2, 2026
@MaximeBICMTL
MaximeBICMTL changed the base branch from main to 29.0-release July 24, 2026 11:42
@MaximeBICMTL MaximeBICMTL added this to the 30.0.0 milestone Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Refactor PR or issue that aims to improve the existing code Language: Javascript PR or issue that update Javascript code Module: electrophysiology_browser PR or issue related to electrophysiology_browser module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant