[electrophysiology_browser] Factorize recording panel and improve typing - #10734
Open
MaximeBICMTL wants to merge 9 commits into
Open
[electrophysiology_browser] Factorize recording panel and improve typing#10734MaximeBICMTL wants to merge 9 commits into
MaximeBICMTL wants to merge 9 commits into
Conversation
MaximeBICMTL
force-pushed
the
ephys-recording-panel-refactor-main
branch
from
July 24, 2026 11:47
43ac5df to
0fc7f94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream of some changes from my MEG/MEEGqc branch so that it does not diverge too much from main.
Summary
This PR mostly moves code around and converts untyped class unfactorized components into typed functional dedicated components:
RecordingSectioncomponent.DetailsPanelcomponent.DownloadPanelandSummaryPanelinto a typed functional component.SidebarandSidebarContentinto a single typed functional component (the CSS is still rather dubious though).Link with other PRs
This PR touches files also touched by two other PR:
The conflicts are rather simple, I will rebase this PR as needed if/when those are merged in main.
Showcase
2026-07-02.17-39-54.mp4