Skip to content

test: ask zm-api for deleted monitors in the live deleted-monitor test #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveGilvarry merged 1 commit into from
Oct 27, 2026
Merged

test: ask zm-api for deleted monitors in the live deleted-monitor test #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/live/test_read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ async def test_deleted_monitors_hidden(
raw = [item.get("Monitor", item) for item in response.get("monitors") or []]
deleted = {int(m["Id"]) for m in raw if m.get("Deleted") in (True, 1, "1")}
else:
items = await zm._paginate("api/v3/monitors") # type: ignore[attr-defined]
# zm-api leaves soft-deleted monitors out unless asked for them.
items = await zm._paginate("api/v3/monitors", include_deleted="true") # type: ignore[attr-defined]
deleted = {int(m["id"]) for m in items if m.get("deleted")}
if not deleted:
pytest.skip("the server has no deleted monitor")
Expand Down
Loading