Repository navigation
test: ask zm-api for deleted monitors in the live deleted-monitor test - #64
Merged
SteveGilvarry merged 1 commit intoOct 27, 2026
Merged
Conversation
zm-api leaves soft-deleted monitors out of api/v3/monitors unless include_deleted is set, so on API v3 the test never found one and always skipped, even on a server that has some. It now asks for them, and checks that get_monitors still leaves them out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
test_deleted_monitors_hidden[v3]always skips. zm-api leaves soft-deleted monitors (Deleted = 1) out ofGET /api/v3/monitorsunlessinclude_deleted=trueis passed, so the test never finds one, even on a server that has someinclude_deleted="true", then checks thatget_monitors()still leaves those monitors out. The v2 path and the library code are unchanged; 1 file, +2/-12ff846av2 passed and v3 skipped ("the server has no deleted monitor"); with this change both passed. Full live suite with writes, both APIs: 50 passed, 4 skipped, 0 failed. ruff, ruff format, mypy pass🤖 Generated with Claude Code