Skip to content

Docs: Document WP_Http_Cookie properties as nullable #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rejaulalomkhan wants to merge 1 commit into from
Closed

Docs: Document WP_Http_Cookie properties as nullable #14182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion phpstan.neon.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ includes:
- tests/phpstan/baselines/booleanAnd.rightAlwaysTrue.neon
- tests/phpstan/baselines/booleanNot.alwaysFalse.neon
- tests/phpstan/baselines/booleanNot.alwaysTrue.neon
- tests/phpstan/baselines/booleanOr.alwaysFalse.neon
- tests/phpstan/baselines/booleanOr.alwaysTrue.neon
- tests/phpstan/baselines/class.notFound.neon
- tests/phpstan/baselines/deadCode.unreachable.neon
Expand Down
4 changes: 2 additions & 2 deletions src/wp-includes/class-wp-http-cookie.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class WP_Http_Cookie {
*
* @since 2.8.0
*
* @var string
* @var string|null
*/
public $name;

Expand All @@ -35,7 +35,7 @@ class WP_Http_Cookie {
*
* @since 2.8.0
*
* @var string
* @var string|null
*/
public $value;

Expand Down
25 changes: 0 additions & 25 deletions tests/phpstan/baselines/booleanOr.alwaysFalse.neon
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions tests/phpstan/baselines/isset.property.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,6 @@ parameters:
identifier: isset.property
count: 1
path: ../../../src/wp-includes/class-wp-http-cookie.php
-
message: '#^Property WP_Http_Cookie\:\:\$name \(string\) in isset\(\) is not nullable\.$#'
identifier: isset.property
count: 1
path: ../../../src/wp-includes/class-wp-http-cookie.php
-
message: '#^Property WP_Http_Cookie\:\:\$value \(string\) in isset\(\) is not nullable\.$#'
identifier: isset.property
count: 1
path: ../../../src/wp-includes/class-wp-http-cookie.php
-
message: '#^Property WP_Post\:\:\$ID \(int\<0, max\>\) in isset\(\) is not nullable\.$#'
identifier: isset.property
Expand Down
Loading