Repository navigation
Docs: Document WP_Http_Cookie properties as nullable - #14182
rejaulalomkhan wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
In WP_Http_Cookie, the and properties are initialized to null before the constructor sets them. When is passed as an associative array without a 'name' key, the constructor returns early, leaving them uninitialized/null. Documenting both as string|null accurately reflects their lifecycle and satisfies PHPStan. This resolves the sole error in the booleanOr.alwaysFalse baseline, retiring it, and removes two entries from the isset.property baseline. See #65817.
7de7999 to
b627399
Compare
|
Thanks for working on this, @rejaulalomkhan! It looks like this overlaps with #13983, which was opened a few days earlier for the same To avoid splitting review effort, would you be open to closing this in favour of #13983? A review there would be very welcome. AI Review: Opus 5.5 |
|
Thanks @huzaifaalmesbah. #13983 covers the same baseline, also documents $domain as nullable, and adds tests for the constructor’s early return, so it’s the more complete fix. Closing in favour of #13983 |
Description
In
WP_Http_Cookie, the$nameand$valueproperties are initialized tonullbefore the constructor sets them. When$datais passed as an associative array without anamekey, the constructor returns early, leaving them uninitialized/null. Documenting both asstring|nullaccurately reflects their lifecycle and satisfies PHPStan.This resolves the sole error in the
booleanOr.alwaysFalsebaseline, retiring it, and removes two entries from theisset.propertybaseline.Use of AI Tools
Yes, an AI assistant was used for research and static analysis inspection. All changes and baseline updates were manually reviewed, verified, and run locally.
Follow-up to [63899], [64222].
Trac ticket: https://core.trac.wordpress.org/ticket/65817
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request outside of WordPress Core Trac.