docs: branch the rjags install instructions by platform (closes #309) - #313
Conversation
.github/copilot-instructions.md told contributors to install rjags with type = "source" on every platform. Both R-CMD-check.yaml and test-coverage.yaml have branched on .Platform$OS.type since #308, using a source build on macOS/Linux and the binary on Windows, so the document contradicted the CI it describes. Split the snippet to match, and note that the Docker snippet earlier in the file stays unconditional because that container is Linux. Closes #309 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017trXKZFoCYC4kP7NKNnN6F
|
/review Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
|
Claude finished review — View run This is a small, accurate documentation fix. Everything checks out. Review: PR #313 — docs: branch the rjags install instructions by platform (closes #309)SummaryThis PR fixes FindingsNo bugs, hallucinations, or CLAUDE.md/lab-manual violations found:
Nothing to flag. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.0",
"reviewer": "claude",
"commit_sha": "e8a8ef9721a726c31854357a2b081c588f2bcffe",
"verdict": "CLEAN",
"findings": []
}Reviewed commit: e8a8ef9 |
Codecov Report✅ All modified and coverable lines are covered by tests. |
Resolve the NEWS.md conflict by keeping both Internal bullets, and re-bump DESCRIPTION past the 0.1.0.9019 that #317 took. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017trXKZFoCYC4kP7NKNnN6F
|
The user asked for this PR to be merged once it is ready, after #317. #317 merged as Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
CI on Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
Closes #309.
What
.github/copilot-instructions.mdtold contributors to installrjagswithtype = "source"on every platform:Both
.github/workflows/R-CMD-check.yamland.github/workflows/test-coverage.yamlhave branched on.Platform$OS.typesince #308 — a source build on macOS/Linux, the binary on Windows:So the document contradicted the CI it describes. This splits the snippet to match, and adds a line noting that the Docker snippet earlier in the file stays unconditional because that container is Linux.
Verified against both workflow files on
mainat5be9001; the branching is byte-identical in each.Scope
Documentation only. No workflow, R code, or test changes.
DESCRIPTIONis bumped to0.1.0.9020(re-bumped in7e671a6after #317 merged with0.1.0.9019) and a NEWS entry added, asversion-checkandCheck Changelog Actionrequire on every PR.Merge order
mainis merged in as of7e671a6, so this PR carries no conflict with it. The remaining open PRs that also bumpDESCRIPTION(#284, #298, #310, #311) will re-bump after this one lands, per the structural collision tracked in #312.No file overlap with any other open PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_017trXKZFoCYC4kP7NKNnN6F