fix(verify-and-ship): pin PR target to origin so forks don't hit upstream - #50
Merged
Merged
Conversation
…ream gh pr create defaults a fork's PR to the upstream parent repo, which silently opened PRs on cyrusagents/cyrus (e.g. cyrusagents#1376, cyrusagents#1369). Derive the target from origin via --repo/--head so the PR always lands on the fork. Claude-Session: https://claude.ai/code/session_01Y7j2xZhmHbNhMRq6665PXy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
gh pr createdefaults a fork's PR to the upstream parent repo. Becauseoriginhere is a fork ofcyrusagents/cyrus, sessions running the verify-and-ship skill silently opened PRs on the public upstream instead of the fork — e.g. cyrusagents#1376 (closed, reopened as fork #49) and cyrusagents#1369 (closed; the work had already merged as fork #29).Fix
The GitHub PR step now derives the target from
originand passes it explicitly, so the PR always lands on the fork:Also adds a load-bearing note explaining the fork default and the "4-digit PR number = wrong repo" red flag.
Docs-only change to
skills/verify-and-ship/SKILL.md.https://claude.ai/code/session_01Y7j2xZhmHbNhMRq6665PXy