Repository navigation
Store the role of a harmonic variable as a HarmonicKind enum - #97
Merged
Merged
Conversation
The kind field replaces the string type field ("u", "v", "a", "Hopf", "").
create_harmonic_variable, remove_brackets and show_ansatz lose their underscore,
since HarmonicBalance and HarmonicSteadyState use them. Breaking, hence 0.6.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HarmonicVariablenow stores its role as aHarmonicKindenum in the fieldkind, replacing the string fieldtype("u","v","a","Hopf",""):typeHarmonicKind"u"CosineQuadrature"v"SineQuadrature"a"ZeroHarmonic"Hopf"LimitCycleFrequency""Unassignedkind_labelgives the short label used in variable names.coordinate_transformthrows anArgumentErrorfor kinds without an ansatz, instead of aKeyErrorfrom aDictlookup.HarmonicBalance and HarmonicSteadyState call three helpers, which therefore lose their underscore:
create_harmonic_variable,remove_bracketsandshow_ansatz.show_ansatz(::HarmonicEquation)had runtime dispatch, which a new JET per-feature entry exposed; it is now type-stable.Breaking, hence version 0.6.0. Merge together with the paired PRs (QuantumEngineeredSystems/HarmonicBalance.jl#539, QuantumEngineeredSystems/HarmonicSteadyState.jl#171), since both downstream packages source QuestBase from
main.Tests: 3452/3452, JET clean. HarmonicBalance 153/153 and HarmonicSteadyState 171/171 against this branch.