Repository navigation
Adapt to the HarmonicKind enum of QuestBase 0.6 - #539
Merged
Merged
Conversation
Revert to main/master once the QuestBase, HarmonicBalance and HarmonicSteadyState PRs are merged.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts to QuestBase 0.6 (QuantumEngineeredSystems/QuestBase.jl#97):
HarmonicVariable.kind::HarmonicKindreplaces the string fieldtype, and the helperscreate_harmonic_variableandremove_bracketshave lost their underscore. Compat is raised toQuestBase = "0.6".The last commit points
[sources]at the pairedrefactor/harmonic-kindbranches so that CI runs against them. Revert it tomain/masteronce the three PRs are merged:Tests against the local branches: HarmonicBalance 153/153, HarmonicSteadyState 171/171.
Stacked on #537.