ERA-13568: Patrol Summary Stats

[luixlive]

What does this PR do?

Calculates and fills the patrol summary stats.

Evidence

Desktop:

Mobile:

Relevant link(s)

• ERA-13568

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a patrol “Summary Stats” section in the Patrol Overview Activity area, including tracked-subject distance selection and localized distance formatting.

Changes:

• Introduced SummaryStats UI with duration/paused/active time, distance (selectable subject), and event count.
• Added tracked-subject distance aggregation via new selectors/utils and a shared formatDistanceInKilometers helper.
• Updated i18n resources and bumped a few JS dependencies.

Reviewed changes

Copilot reviewed 28 out of 30 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
yarn.lock	Updates lockfile for bumped dependencies.
package.json	Bumps Auth0 React, Testing Library user-event, eslint-plugin-jest, and globals.
src/utils/patrols.js	Adds elapsed/paused time helpers and tracked-subject extraction for segments.
src/utils/distance.js	Adds centralized i18n-aware km formatting helper.
src/selectors/patrols/index.js	Adds selectors to derive tracked subjects and distance covered per segment.
src/i18n.js	Bumps i18n files version to invalidate cached translations.
src/hooks/useCurrentTime.js	Adds a hook to refresh “now” on an interval for live elapsed-time UI.
src/common/images/icons/star.svg	Adds star icon for “patrol leader” indicator in subject menu.
src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/styles.module.scss	Removes old stats-row styling (moved to SummaryStats).
src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/index.js	Replaces inline stats markup with SummaryStats.
src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/index.test.js	Extends test store state with tracks.
src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/SummaryStats/index.js	New component implementing the summary stats + tracked-subject distance menu.
src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/SummaryStats/styles.module.scss	New styles for summary stats grid and the subject selection popover.
src/Patrols/DistanceCovered.js	Uses shared distance formatter; simplifies distance calculation.
src/PatrolTrackLegend/index.js	Uses shared distance formatter; simplifies distance calculation and rendering.
src/PatrolListItem/index.js	Updates PatrolDistanceCovered usage (removes suffix).
src/PatrolDetailView/Header/index.js	Updates PatrolDistanceCovered usage (removes suffix).
public/locales/en-US/utils.json	Adds utils.distanceInKilometers translation key.
public/locales/es/utils.json	Adds utils.distanceInKilometers translation key.
public/locales/fr/utils.json	Adds utils.distanceInKilometers translation key.
public/locales/ne-NP/utils.json	Adds utils.distanceInKilometers translation key.
public/locales/pt/utils.json	Adds utils.distanceInKilometers translation key.
public/locales/sw/utils.json	Adds utils.distanceInKilometers translation key.
public/locales/en-US/patrols.json	Moves activity stat labels under summaryStats keyPrefix.
public/locales/es/patrols.json	Moves activity stat labels under summaryStats keyPrefix.
public/locales/fr/patrols.json	Moves activity stat labels under summaryStats keyPrefix.
public/locales/ne-NP/patrols.json	Moves activity stat labels under summaryStats keyPrefix.
public/locales/pt/patrols.json	Moves activity stat labels under summaryStats keyPrefix.
public/locales/sw/patrols.json	Moves activity stat labels under summaryStats keyPrefix.
AGENTS.md	Updates docs to mention stats heading the activity timeline.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 44 out of 46 changed files in this pull request and generated no new comments.

Suppressed comments (7)

src/utils/tracks.js:1

• trackLengthWithinTimeRange will throw if trackData/trackData.track/trackData.track.features is missing (e.g., caller passes null or partially-loaded track data). Add an initial guard (similar to other track utils) before destructuring trackData.track.features, returning 0 when the track container is absent.
  src/utils/tracks.js:1
• This assumes trackFeature.properties.coordinateProperties.times always exists when from/until is provided. If geometry is present but coordinateProperties.times is missing, this will throw. Consider guarding for a missing/empty times array and returning 0 (or falling back to measuring all coordinates) to avoid runtime errors.
  src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/SummaryStats/index.js:133
• Preventing default on Tab and forcing focus back to the trigger breaks expected keyboard navigation (Tab should typically move focus to the next focusable element). Consider only closing the menu on Tab without preventDefault (or follow the ARIA menu-button pattern by using a component that manages focus/Tab semantics).

    case 'Tab':
    case 'Escape':
      event.preventDefault();

      onDistanceSubjectMenuClose();

      break;

src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/SummaryStats/index.js:56

• Using a state setter as a ref callback stores a DOM node in state and can introduce avoidable re-renders (and StrictMode double-invoke ref churn). Prefer useRef for the anchor element (e.g., const anchorRef = useRef(null) and ref={anchorRef}), and read anchorRef.current for Overlay.target and focus management.

  const [distanceSubjectMenuAnchorEl, setDistanceSubjectMenuAnchorEl] = useState();

src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/SummaryStats/index.js:162

• Using a state setter as a ref callback stores a DOM node in state and can introduce avoidable re-renders (and StrictMode double-invoke ref churn). Prefer useRef for the anchor element (e.g., const anchorRef = useRef(null) and ref={anchorRef}), and read anchorRef.current for Overlay.target and focus management.

      <button

src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/SummaryStats/index.js:169

• Using a state setter as a ref callback stores a DOM node in state and can introduce avoidable re-renders (and StrictMode double-invoke ref churn). Prefer useRef for the anchor element (e.g., const anchorRef = useRef(null) and ref={anchorRef}), and read anchorRef.current for Overlay.target and focus management.

        ref={setDistanceSubjectMenuAnchorEl}

src/SideBar/PatrolsManager/PatrolOverview/Overview/Activity/SummaryStats/index.js:73

• Since paused-time detection is intended to be implemented later, it would be safer to clamp activeTime to a minimum of 0 (e.g., Math.max(0, duration - pausedTime)) to avoid negative values if the paused-time calculation ever exceeds total duration due to data issues or edge cases.

  const { activeTime, duration, pausedTime } = useMemo(() => {
    const duration = getElapsedTimeForPatrol(patrol, currentTime);
    const pausedTime = getPausedTimeForPatrol(patrol, currentTime);

    return { activeTime: duration - pausedTime, duration, pausedTime };
  }, [currentTime, patrol]);