Skip to content

refactor(configurl): rename ProviderContainer to Registry - #646

Merged
fortuna merged 1 commit into
mainfrom
refactor/configurl-registry
Oct 19, 2026
Merged

fortuna merged 1 commit into
mainfrom
refactor/configurl-registry

Conversation

@fortuna

@fortuna fortuna commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Rename the config URL component container from ProviderContainer to Registry, with NewRegistry, NewDefaultRegistry, and RegisterDefaultTypes as the preferred entry points. This better aligns with the language we’ve been using.

Preserve existing Go source compatibility through a deprecated ProviderContainer type alias and forwarding wrappers for the old function names.

Update SDK callers and Go documentation to use the new names. Add external-package compatibility checks for old/new pointers, composite literals, function signatures, and method expressions, plus tests for constructor defaults and preservation of custom registrations/base instances. The defined type's reflected name becomes Registry.

Validation:

  • GOMAXPROCS=2 GOFLAGS=-p=2 go test -C x -race ./...
  • GOMAXPROCS=2 GOFLAGS=-p=2 go -C x tool staticcheck ./...
  • Checked the rendered API text with go doc for both Registry and the deprecated alias.

@fortuna
fortuna marked this pull request as ready for review October 17, 2026 15:26
@fortuna
fortuna requested a review from ohnorobo October 17, 2026 15:27
@greptile-apps

greptile-apps Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; the rename preserves existing Go source usage and dialer behavior.

Summary

Renames ProviderContainer to Registry and adds the preferred constructor and registration names.

  • Registry is the preferred name for building network objects from config URLs.
  • SDK examples, tools, and docs use the new Registry names.

No actionable issues found. Related repositories were checked for uses of the renamed API. Tests were inspected, not run.

Acknowledged intent: fortuna explicitly states that the reflected type name becomes Registry; this is not treated as a compatibility defect.

Reviews (1) · Last reviewed commit: "refactor(configurl): rename ProviderCont..." · Reviewed by Greptile

Comment thread x/configurl/registry_compat_test.go
@fortuna
fortuna merged commit 9b46f8f into main Oct 19, 2026
8 checks passed
@fortuna
fortuna deleted the refactor/configurl-registry branch October 19, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants