Repository navigation
refactor(configurl): rename ProviderContainer to Registry - #646
Merged
Merged
Conversation
fortuna
marked this pull request as ready for review
October 17, 2026 15:26
[Medium impact] The PR appears safe to merge; the rename preserves existing Go source usage and dialer behavior. SummaryRenames
No actionable issues found. Related repositories were checked for uses of the renamed API. Tests were inspected, not run. Acknowledged intent: fortuna explicitly states that the reflected type name becomes Reviews (1) · Last reviewed commit: "refactor(configurl): rename ProviderCont..." · Reviewed by Greptile |
ohnorobo
approved these changes
Oct 19, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the config URL component container from
ProviderContainertoRegistry, withNewRegistry,NewDefaultRegistry, andRegisterDefaultTypesas the preferred entry points. This better aligns with the language we’ve been using.Preserve existing Go source compatibility through a deprecated
ProviderContainertype alias and forwarding wrappers for the old function names.Update SDK callers and Go documentation to use the new names. Add external-package compatibility checks for old/new pointers, composite literals, function signatures, and method expressions, plus tests for constructor defaults and preservation of custom registrations/base instances. The defined type's reflected name becomes
Registry.Validation:
GOMAXPROCS=2 GOFLAGS=-p=2 go test -C x -race ./...GOMAXPROCS=2 GOFLAGS=-p=2 go -C x tool staticcheck ./...go docfor bothRegistryand the deprecated alias.