Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SmartDialer currently creates separate configurl providers for TLS and fallback searches, so applications cannot consistently register custom components or inject base dialers across those paths. This change lets SmartDialer and Mobileproxy use a configured registry throughout DNS discovery, TLS construction, and fallback parsing.
configurl.RegistryexposesLookupParser;MutableRegistryadds registration. GenericNew,Parse,Register, andLookupsupport arbitrary result types.MakeNew[T](registry)supplies a bound dependency function, so component parsers take only context and config. Built-in registration helpers retain explicit dependencies.RegisterBaseinstalls a parser;RegisterInstanceinjects an existing value. Smart options accept a mutable registry and wrap its default stream parser once on the first successfulNew(), after all component/base registrations are complete.StrategyFinderOptionsprovides fluent setup and validation. Mobileproxy exposes its registry to Go component helpers and fallback parsers. Deprecated finder dialer fields remain supported through first-use normalization and are mutually exclusive with an explicitly configured registry.The released concrete
ProviderContainerAPI remains intact, without rename aliases or deprecations. The unreleased concreteRegistryAPI from #646 is replaced by these interfaces; existing provider callers retain their original API.Validation: full
xmodule race suite and staticcheck pass. Coverage includes external registry implementations, arbitrary result types, bound dependency lookup, concurrent TLS searches, nested configs, DNS dialer identity/cache reuse, fallback isolation after TLS failure, cached YAML fallbacks, legacy compatibility, and Mobileproxy registration. Java and Objective-C binding generation passes with a custom component wrapper; native Android/iOS packaging was not run locally.Keep this PR in draft. Developer documentation follow-ups remain held until the final API is released in the
xmodule.