Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol V2 resource writes currently check transfer acknowledgements and file size, but do not read back the written package header. Read it back in loader mode and reuse the existing size/version/payload-hash/header-hash comparison, including forced updates and the actual staging path.
Successful calls containing resources return
resourceVerification: "header-verified"; unchanged resources must pass the existing comparison. Resource write or read-back failures carryparams.resourceVerification: "failed"while preserving existing hardware error codes. Calls without resources omit the field.This checks package headers, not a fresh hash of the full on-device payload or resource mounting after reboot. It reuses the filesystem commands supported by bootloader 1.0.0 and does not change reboot orchestration or device permissions. Read-back adds 24,464 bytes per written package, using the existing transport read limits.
Companion App reporting: OneKeyHQ/app-monorepo#13255
Validation:
yarn agent:check --profile commitand--profile prpassed, including Core tests (1,306 passed; 4 skipped), full lint/tests/build and package version consistency. Focused regression cases cover forced writes, staging-path read-back, matching headers and stale headers. No physical-device run.