Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing firmware update result cannot distinguish overall update success from resource verification. Forward the SDK's optional
resourceVerificationinto the existingfirmwareUpdateResultlocal log and Mixpanel event.header-verified: the requested resource package headers matched the target packages in loader mode.failed: the SDK reported a resource write/read-back failure, including when the user leaves the retry screen.The result belongs to the current workflow and is cleared on a new workflow. This adds no per-file events or dependency upgrades. Merge and release together with the companion SDK change. Header verification does not attest full payload read-back or runtime resource mounting.
Companion SDK verification: OneKeyHQ/hardware-js-sdk#927
Validation: 77 ServiceFirmwareUpdate detection/workflow tests passed;
yarn agent:check --profile commitand local checks in--profile prpassed, including TypeScript. No physical-device run.