[18.0][MIG] pos_payment_change: Migration to 18.0 by victoralmau · Pull Request #1573 · OCA/pos

victoralmau · 2026-06-22T15:52:05Z

Migration to 18.0

Superseed #1453

Changes done:

Invoiced order domain compatibility ([18.0][MIG] pos_payment_change: Migration to 18.0 #1453 (review)).
Add Payment Date column to wizard
Show the “Change Payments” button only when the status is “invoiced” (if payment_change_policy=update).
Improve tests

- Black python code - OCA Convention - Add tests - add configuration on pos.config, with two option 'refund' or 'update' - The 'refund' option makes the module compatible with (French) certification - make the module compatible with pos_order_return

…on PoS Order(s) to know the history of the payments

…ontrol ; [ADD] display old payment lines

Translated using Weblate (Spanish) Currently translated at 100.0% (31 of 31 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

add new line Pylint fix pylint

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Translated using Weblate (German) Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/de/

A cash payment method must have a cash journal.

[UPD] Update pos_payment_change.pot [UPD] README.rst

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/

Translated using Weblate (Italian) Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/it/ [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/fr/

In old version, two certifications modules was present in odoo. l10n_fr_pos_cert and l10n_fr_certification. In odoo 16, only l10n_fr_pos_cert exists. [BOT] post-merge updates

…e obsolete Warning

[BOT] post-merge updates

Better readme FIX OCA#1115 [BOT] post-merge updates

[BOT] post-merge updates

Translated using Weblate (Portuguese (Portugal)) Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/pt_PT/

[FIX] pos_payment_change: rebase test on TestPoSCommon [FIX] pos_payment_change: in tests replace Marc Demo to user with explicit rights [FIX] pos_payment_change: add compatibility with pos_order_copy Co-authored-by: Eugene Molotov <molotov@it-projects.info> [UPD] Update pos_payment_change.pot [BOT] post-merge updates

Co-authored-by: Abraham Anes <abrahamanes@gmail.com>

psycopg2.errors.ForeignKeyViolation: insert or update on table "pos_order" violates foreign key constraint "pos_order_partner_id_fkey" DETAIL: Key (partner_id)=(44) is not present in table "res_partner

Changes done: - Remove context (TestPoSCommon already has it) - Use the new_test_user() method to create users - Use the BaseCommon class

pedrobaeza · 2026-06-23T08:10:31Z

/ocabot migration pos_payment_change

If the main goal of the module is already covered, shouldn't this be renamed or to start a new one with the missing feature?

victoralmau · 2026-06-23T08:37:11Z

If the main goal of the module is already covered, shouldn't this be renamed or to start a new one with the missing feature?

I actually think the module's name is appropriate because its purpose is to modify pos payments when Odoo Core doesn't allow it.

pedrobaeza · 2026-06-23T14:26:45Z

Yes, but it's too generic. Now that feature is covered by core, except the case where the order has been invoiced, so the module name should reflect it.

victoralmau · 2026-06-23T14:29:51Z

Yes, but it's too generic. Now that feature is covered by core, except the case where the order has been invoiced, so the module name should reflect it.

It is important to remember that this module also includes the “Refund and Resale” option (at the pos.config level), which is allowed when the order is in the ‘paid’ or “invoiced” status.

pedrobaeza · 2026-06-23T14:31:18Z

Yes, and that's why I'm saying that the module is now other thing. I would say pos_after_invoice_mgmt for example.

victoralmau · 2026-06-23T14:34:19Z

Yes, and that's why I'm saying that the module is now other thing. I would say pos_after_invoice_mgmt for example.

Okay, so I'll rename the module to pos_after_invoice_mgmt, and we'll keep all the functionality there? (including the “Refund and Resale” functionality for the “paid” status)

pedrobaeza · 2026-06-23T14:37:11Z

Let's see what @legalsylvain thinks. For us, AFAIK, we only need the other part.

legalsylvain and others added 30 commits June 22, 2026 17:41

[IMP] use refund() to resale order (in 'refund' mode) ; [ADD] a note …

3493002

…on PoS Order(s) to know the history of the payments

[FIX] error in balance computation if change is done during closing c…

87c9b7b

…ontrol ; [ADD] display old payment lines

Update __manifest__.py

c28f192

[FIX] access to ir.module.module should be done with sudo

0ac84af

Added translation using Weblate (Spanish)

0d58501

Translated using Weblate (Spanish) Currently translated at 100.0% (31 of 31 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Use currency and monetary so that rounding will be done by the ORM*

555f353

add new line Pylint fix pylint

more fix pyilint

2f6430f

Translated using Weblate (Spanish)

b1a6d8c

Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/es/

Added translation using Weblate (German)

dc22c0e

Translated using Weblate (German) Currently translated at 100.0% (33 of 33 strings) Translation: pos-12.0/pos-12.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_payment_change/de/

[IMP] pos_payment_change: isort, black, prettier.

3878563

[MIG] Migrate module pos_payment_change to v14.

9fc45fd

[FIX] pos_payment_change: fix test

a02f313

A cash payment method must have a cash journal.

[MIG]pos_payment_change: Migration to 15.0

e4b67c6

[WIP] pos_payment_change: Migration to 16.0

fce608f

[FIX] the method _check_pos_session_balance is deleted in point_of_sale

3a53143

[FIX] use float_compare to compare floats

1b6637e

[MIG] pos_payment_change: modification wizard view, add widget selection

73b8626

[UPD] Update pos_payment_change.pot [UPD] README.rst

Translated using Weblate (Spanish)

39578ad

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/

Translated using Weblate (Spanish)

c9f0de8

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/

Translated using Weblate (French)

6e36d4a

Currently translated at 100.0% (33 of 33 strings) Translation: pos-16.0/pos-16.0-pos_payment_change Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/fr/

[FIX] pos_payment_change : check installation fo existing modules.

067d17e

In old version, two certifications modules was present in odoo. l10n_fr_pos_cert and l10n_fr_certification. In odoo 16, only l10n_fr_pos_cert exists. [BOT] post-merge updates

[FIX] use right method to access action in change payment - remove th…

3ac3f05

…e obsolete Warning

more concise test

ebe7832

[BOT] post-merge updates

[DOC]Appropriate readm for v16

ef1146d

Better readme FIX OCA#1115 [BOT] post-merge updates

[FIX] pos_payment_change: ondelete='cascade' for O2M fields

6b6a2fe

[BOT] post-merge updates

[REF] pos_payment_change: move pos config in res.config.settings

56397fe

[IMP] pos_payment_change: pre-commit auto fixes

b476e4c

em230418 and others added 2 commits June 22, 2026 17:46

[IMP] pos_payment_change: pre-commit auto fixes

7913f5d

OCA-git-bot added series:18.0 mod:pos_payment_change Module pos_payment_change labels Jun 22, 2026

victoralmau mentioned this pull request Jun 22, 2026

[18.0][MIG] pos_payment_change: Migration to 18.0 #1453

Closed

OCA-git-bot added the mod:pos_user_restriction Module pos_user_restriction label Jun 23, 2026

Abranes and others added 3 commits June 23, 2026 09:01

[MIG] pos_payment_change: Migration to 18.0

c5d89d5

Co-authored-by: Abraham Anes <abrahamanes@gmail.com>

[FIX] pos_user_restriction: Fix tests to avoid error

accf635

psycopg2.errors.ForeignKeyViolation: insert or update on table "pos_order" violates foreign key constraint "pos_order_partner_id_fkey" DETAIL: Key (partner_id)=(44) is not present in table "res_partner

[IMP] pos_user_restriction: Improve tests

7ec84d3

Changes done: - Remove context (TestPoSCommon already has it) - Use the new_test_user() method to create users - Use the BaseCommon class

victoralmau force-pushed the 18.0-mig-pos_payment_change branch from 718d2dd to 7ec84d3 Compare June 23, 2026 07:01

OCA-git-bot added this to the 18.0 milestone Jun 23, 2026

OCA-git-bot mentioned this pull request Jun 23, 2026

Migration to version 18.0 #1251

Open

34 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] pos_payment_change: Migration to 18.0#1573

[18.0][MIG] pos_payment_change: Migration to 18.0#1573
victoralmau wants to merge 35 commits into
OCA:18.0from
Tecnativa:18.0-mig-pos_payment_change

victoralmau commented Jun 22, 2026

Uh oh!

pedrobaeza commented Jun 23, 2026

Uh oh!

victoralmau commented Jun 23, 2026

Uh oh!

pedrobaeza commented Jun 23, 2026

Uh oh!

victoralmau commented Jun 23, 2026

Uh oh!

pedrobaeza commented Jun 23, 2026

Uh oh!

victoralmau commented Jun 23, 2026

Uh oh!

pedrobaeza commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Uh oh!

Conversation

victoralmau commented Jun 22, 2026

Uh oh!

pedrobaeza commented Jun 23, 2026

Uh oh!

victoralmau commented Jun 23, 2026

Uh oh!

pedrobaeza commented Jun 23, 2026

Uh oh!

victoralmau commented Jun 23, 2026

Uh oh!

pedrobaeza commented Jun 23, 2026

Uh oh!

victoralmau commented Jun 23, 2026

Uh oh!

pedrobaeza commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants