Skip to content

[18.0][MIG] pos_payment_change: Migration to 18.0#1453

Closed
Abranes wants to merge 45 commits into
OCA:18.0from
Abranes:18.0-mig-pos_payment_change
Closed

[18.0][MIG] pos_payment_change: Migration to 18.0#1453
Abranes wants to merge 45 commits into
OCA:18.0from
Abranes:18.0-mig-pos_payment_change

Conversation

@Abranes

@Abranes Abranes commented Nov 9, 2025

Copy link
Copy Markdown
Member

Migration to 18.0 from #1331

@Abranes Abranes force-pushed the 18.0-mig-pos_payment_change branch from 0fb2a05 to 4c9439a Compare November 9, 2025 22:25

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff review. LGTM. Thanks !

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration pos_payment_change

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Nov 10, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 10, 2025
34 tasks
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-1453-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 10, 2025
Signed-off-by pedrobaeza
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1453-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1453-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 10, 2025
Signed-off-by pedrobaeza
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1453-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only OCB is failing due to a tour... let's try again

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1453-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 10, 2025
Signed-off-by pedrobaeza
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1453-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza

Copy link
Copy Markdown
Member

There's no way...

@flotho

flotho commented Jan 10, 2026

Copy link
Copy Markdown
Member

looks like the same as #1455 (comment)

@HaraldPanten

Copy link
Copy Markdown

@pedrobaeza could you retry the merge command? Or do you think it will fail again?

THX.

@pedrobaeza

Copy link
Copy Markdown
Member

I think this will fail while #241122 is not merged.

@HaraldPanten

Copy link
Copy Markdown

THX @pedrobaeza .

By the way... are you sure that this module is needed in >17.0 ? I see that Odoo has an option for this. Isn't this functionallity included in core? (see screensot).

Captura de pantalla 2026-02-04 a las 14 13 50

And it can be changed using backend options by entering the changes directly in the pos order, as well.

@Abranes @legalsylvain

@HaraldPanten

Copy link
Copy Markdown

@Abranes @legalsylvain Could you check my comments?

THX!

mymage and others added 21 commits May 27, 2026 09:52
Currently translated at 100.0% (33 of 33 strings)

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/
Currently translated at 100.0% (33 of 33 strings)

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/es/
Currently translated at 100.0% (33 of 33 strings)

Translation: pos-16.0/pos-16.0-pos_payment_change
Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_payment_change/fr/
In old version, two certifications modules was present in odoo.  l10n_fr_pos_cert and l10n_fr_certification.
In odoo 16, only l10n_fr_pos_cert exists.
@Abranes Abranes force-pushed the 18.0-mig-pos_payment_change branch from 0d55ab2 to c1b2008 Compare May 27, 2026 07:52
@OCA-git-bot OCA-git-bot added series:18.0 mod:pos_payment_change Module pos_payment_change labels May 27, 2026

@legalsylvain legalsylvain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff review. LGTM.

@victoralmau victoralmau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not working properly

  • In pos.config, we set Payment Change Policy=Update Payments
  • In POS, we create an order linked to a customer with an invoice and pay with cash
  • In the backend, in pos.order, we use the wizard to select bank, but an error appears
Image Image

@victoralmau

Copy link
Copy Markdown
Member

Superseed by #1573

@pedrobaeza pedrobaeza closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.