Skip to content

Repository navigation

chore(core): cover generated minimap item keys #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cursor wants to merge 1 commit into from
Closed

chore(core): cover generated minimap item keys #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions projects/core/src/viewport/viewport-minimap.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,22 @@ describe(ViewportMinimap.metadata.tag, () => {
expect(firstKey).toHaveLength(1);
});

it('assigns stable generated keys to automatic roots without an id', async () => {
const root = viewport.querySelector<HTMLElement>('#automatic-root')!;
root.removeAttribute('id');
const sibling = document.createElement('div');
vi.spyOn(sibling, 'getBoundingClientRect').mockReturnValue(rect({ x: 40, y: 50, width: 20, height: 20 }));
viewport.append(sibling);
await elementIsStable(viewport);
minimap.refresh();
await flushProjection(minimap);
expect(itemKeys(minimap)).toEqual(['root-0', 'root-1']);

minimap.refresh();
await flushProjection(minimap);
expect(itemKeys(minimap)).toEqual(['root-0', 'root-1']);
});

it('rebuilds automatic roots on default-slot changes while excluding background and overlay children', async () => {
const added = document.createElement('div');
added.id = 'added-root';
Expand Down
Loading