Repository navigation
chore(core): cover generated minimap item keys - #404
Closed
cursor[bot] wants to merge 1 commit into
Closed
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Adds a unit test for automatic viewport roots that have no id. Line coverage in viewport-minimap.ts rises from 97.41% to 100%, and branch coverage rises from 82.96% to 85.18%. No behavior change. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Coverage. The selector chose
projects/core/src/viewport/viewport-minimap.tsbecause it had "6 uncovered lines, 97.41% lines and 82.96% branches, the smallest gap below the 90% threshold".Measurement
No other file's coverage decreased. Core unit tests: 2380 passed.
API
No public API changed. The diff is tests only.
Left alone
Twenty defensive branches remain, including a missing viewport, a parent that is not a viewport, disconnect races, a missing preview wrapper, zero-size roots, pointer-id mismatches, and a pan session that never starts. Line coverage is complete, so the selector will not choose this file for those branches.