Ci triggers matrix - #46
Conversation
Removed code linting job from CI workflow.
📝 WalkthroughWalkthroughThis PR removes twelve GitHub Actions workflow files covering code quality, testing, DAST, dependency scanning, deployment, DevSecOps orchestration, Docker push/scan, Go linting, secret scanning, and SonarQube analysis, and adds a new minimal pr-check.yml workflow that logs the PR head branch name on pull requests to master. ChangesCI/CD Workflow Overhaul
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pr-check.yml:
- Around line 12-13: The workflow step in pr-check.yml has a YAML parsing issue
because the run value in the Print PR branch step contains an unquoted
colon+space, so quote the entire echo command string to make it valid YAML.
Update the run content in the Print PR branch step so the shell command is
treated as plain text and the workflow can load successfully. Refer to the Print
PR branch step and its run field when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: abe09843-5a26-4856-8ec1-d71345cc730a
📒 Files selected for processing (12)
.github/workflows/code-quality.yml.github/workflows/code-tests.yml.github/workflows/dast.yml.github/workflows/dependency-scan.yml.github/workflows/deploy.yml.github/workflows/devsecops.yml.github/workflows/docker-push.yml.github/workflows/docker-scans.yml.github/workflows/matrix.yml.github/workflows/pr-check.yml.github/workflows/secret-scanning.yml.github/workflows/sonar-scan.yml
💤 Files with no reviewable changes (11)
- .github/workflows/secret-scanning.yml
- .github/workflows/sonar-scan.yml
- .github/workflows/dast.yml
- .github/workflows/devsecops.yml
- .github/workflows/code-quality.yml
- .github/workflows/docker-push.yml
- .github/workflows/deploy.yml
- .github/workflows/matrix.yml
- .github/workflows/dependency-scan.yml
- .github/workflows/code-tests.yml
- .github/workflows/docker-scans.yml
| - name: Print PR branch | ||
| run: echo "PR check running for branch: ${{ github.head_ref }}" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
YAML syntax error breaks the workflow.
The unquoted run value contains branch: (colon+space), which YAML parses as a nested mapping key rather than plain text. This is confirmed by both yamllint and actionlint reporting a parse failure at line 13 — the workflow will fail to load and the job will never execute.
🐛 Proposed fix: quote the run string
- name: Print PR branch
- run: echo "PR check running for branch: ${{ github.head_ref }}"
+ run: echo "PR check running for branch: ${{ github.head_ref }}"Actually wrap the whole value in single quotes so the embedded colon is safe:
- name: Print PR branch
- run: echo "PR check running for branch: ${{ github.head_ref }}"
+ run: 'echo "PR check running for branch: ${{ github.head_ref }}"'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: Print PR branch | |
| run: echo "PR check running for branch: ${{ github.head_ref }}" | |
| - name: Print PR branch | |
| run: 'echo "PR check running for branch: ${{ github.head_ref }}"' |
🧰 Tools
🪛 actionlint (1.7.12)
[error] 13-13: could not parse as YAML: mapping values are not allowed in this context
(syntax-check)
🪛 YAMLlint (1.37.1)
[error] 13-13: syntax error: mapping values are not allowed here
(syntax)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/pr-check.yml around lines 12 - 13, The workflow step in
pr-check.yml has a YAML parsing issue because the run value in the Print PR
branch step contains an unquoted colon+space, so quote the entire echo command
string to make it valid YAML. Update the run content in the Print PR branch step
so the shell command is treated as plain text and the workflow can load
successfully. Refer to the Print PR branch step and its run field when making
the change.
Source: Linters/SAST tools
|
1 participant
Summary by CodeRabbit
New Features
Chores