chore: install sumit-api from npm instead of file: link#13
Merged
Conversation
sumit-api is published to npm (0.4.0), so the dev dependency no longer needs the file:../sumit-api sibling link. Update the README local development section accordingly and document pnpm link for developing against a local checkout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
With sumit-api installed from npm, CI no longer needs to check out and build the sibling repo before installing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The dev dependency now installs sumit-api from npm; document pnpm link for working against a local checkout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
happy-dom ^15 carried a critical VM-context-escape advisory (fixed in 20.x) plus two high ones; the stale lockfile also held vitest's transitive vite at 8.0.10 (fs.deny bypass, launch-editor NTLMv2 disclosure — both patched in 8.0.16). Bump happy-dom to ^20.8.9 and regenerate the lockfile (vitest 4.1.9, vite 8.1.3). pnpm audit is now clean; typecheck, tests (31/31) and build all pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
sumit-apihas been on npm since 0.4.0, but the dev dependency still pointed atfile:../sumit-apiand the README still said the package was "being published". A fresh clone without a sibling checkout failed to install.Changes
devDependencies:sumit-api→^0.4.0(installed from the registry; peer range unchanged).pnpm link ../sumit-apifor developing against a local checkout.Verification
pnpm install,pnpm typecheck,pnpm test(31/31),pnpm build— all green with the registry-sourced dependency.🤖 Generated with Claude Code