fix: address outstanding Codex review findings#14
Merged
Conversation
Codex findings on #12: the 0.2.0 changelog advertised the SumitChargeMode type export but the ./next barrel never re-exported it, and an unknown mode from an untyped consumer resolved DEFAULT_PATHS[mode] to undefined, sending requests to https://api.sumit.co.ilundefined. Export the type and fail fast with a clear configuration error. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codex findings on #4 and #7: workflow_dispatch could publish from any ref (now main-only), the sumit-api sibling checkout was unpinned and is now unnecessary (the dependency installs from npm), and the GitHub Packages workflow pointed installs at npm.pkg.github.com where public packages don't resolve — the publish step configures that registry and its auth itself. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1cb5fc0248
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex follow-up on the new mode guard: `in` walks the prototype chain, so mode: "toString" passed validation and resolved DEFAULT_PATHS to an inherited function. Compare against the two known modes explicitly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A sweep of all Codex review comments across the repo's PR history found five findings never addressed (the peer-range finding from #11 was already fixed when 0.2.0 bumped it).
Changes
SumitChargeModeadvertised in the 0.2.0 changelog but never re-exported from the./nextbarreldist/next/index.d.ts.mode(e.g."oneoff"from a JS consumer) resolvesDEFAULT_PATHS[mode]toundefined→ requests go tohttps://api.sumit.co.ilundefinedcreateSumitChargeRoutevalidatesmodeand throws a clear configuration error at creation time. Test added.sumit-apiat an unpinned refworkflow_dispatchcan publish from any branchmain.registry-url: npm.pkg.github.combefore install, so public deps (react, vitest…) resolve against the wrong registryVerification
pnpm typecheckclean,pnpm test32/32 (new invalid-mode test),pnpm buildgreen,SumitChargeModepresent in the builtd.ts.🤖 Generated with Claude Code