Skip to content

fix: validate Python module syntax during module_manager install #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HaibinLai wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: validate Python module syntax during module_manager install #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions bmf/cmd/src/module_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,32 @@ int install_module(const bmf_sdk::ModuleInfo &info, bool force) {
(module_file + bmf_sdk::SharedLibrary::default_extension()))
.string();
} else {
// python module
module_file =
(fs::path(info.module_path) / (module_file + ".py")).string();
if (fs::exists(module_file)) {
// validate python syntax before installing
std::string check_cmd =
"python3 -m py_compile \"" + module_file + "\" 2>&1";
FILE *pipe = popen(check_cmd.c_str(), "r");
if (pipe) {
char buffer[256];
std::string result;
while (fgets(buffer, sizeof(buffer), pipe) != nullptr) {
result += buffer;
}
int status = pclose(pipe);
if (status != 0) {
BMFLOG(BMF_ERROR)
<< "Python syntax check failed for: "
<< module_file << std::endl;
if (!result.empty()) {
BMFLOG(BMF_ERROR) << result << std::endl;
}
return -1;
}
}
}
}
if (!fs::exists(module_file)) {
BMFLOG(BMF_ERROR)
Expand Down