fix: validate Python module syntax during module_manager install#213
Open
HaibinLai wants to merge 1 commit into
Open
fix: validate Python module syntax during module_manager install#213HaibinLai wants to merge 1 commit into
HaibinLai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module_manager installpreviously accepted Python modules with syntax errors (e.g.IndentationError) without any validation. The error was only discovered at runtime when the BMF graph attempted to load the module, causing a crash.This PR adds a
py_compilesyntax check in theinstall_module()function for Python modules. If the syntax check fails, the installation is aborted with a error message showing the syntax error and line number.relate issue: #193
How to Reproduce
Before this fix, the installation reports success even though the module contains invalid Python syntax.
After this fix, the installation fails early with a clear error message: