Skip to content

fix(No Recommended): Enable blog/community carousel hiding in masonry views #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcustyphoon wants to merge 2 commits into from
Open

fix(No Recommended): Enable blog/community carousel hiding in masonry views #2352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a43d243
Update hide_blog_carousels.js
marcustyphoon Aug 26, 2026
d77c3d2
Update hide_community_carousels.js
marcustyphoon Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/features/no_recommended/hide_blog_carousels.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { keyToCss } from '../../utils/css_map.js';
import { buildStyle, getTimelineItemWrapper } from '../../utils/interface.js';
import { pageModifications } from '../../utils/mutations.js';
import { timelineObject } from '../../utils/react_props.js';
import { timelineSelector } from '../../utils/timeline_id.js';

const hiddenAttribute = 'data-no-recommended-blog-carousels-hidden';

Expand All @@ -12,24 +13,32 @@ export const styleElement = buildStyle(`
`);

const carouselSelector = `${keyToCss('listTimelineObject')} ${keyToCss('carouselWrapper')}`;
const masonryCarouselSelector = `${keyToCss('desktopContainer')} > ${keyToCss('recommendedBlogs')}`;

const hideBlogCarousels = carousels =>
carousels.forEach(async carousel => {
const { elements } = await timelineObject(carousel);
if (elements.some(({ objectType }) => objectType === 'blog')) {
const timelineItem = getTimelineItemWrapper(carousel);
if (
timelineItem.previousElementSibling.querySelector(keyToCss('titleObject')) ||
timelineItem.previousElementSibling.dataset.cellId?.startsWith('timelineObject:title')
timelineItem.previousElementSibling?.querySelector(keyToCss('titleObject')) ||
timelineItem.previousElementSibling?.dataset.cellId?.startsWith('timelineObject:title')
) {
timelineItem.toggleAttribute(hiddenAttribute, true);
timelineItem.previousElementSibling.toggleAttribute(hiddenAttribute, true);
} else if (
timelineItem.querySelector(keyToCss('titleObject'))
) {
timelineItem.toggleAttribute(hiddenAttribute, true);
}
}
});

export const main = async function () {
pageModifications.register(carouselSelector, hideBlogCarousels);
pageModifications.register(
`${timelineSelector} :is(${carouselSelector}, ${masonryCarouselSelector})`,
hideBlogCarousels,
);
};

export const clean = async function () {
Expand Down
15 changes: 12 additions & 3 deletions src/features/no_recommended/hide_community_carousels.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { keyToCss } from '../../utils/css_map.js';
import { buildStyle, getTimelineItemWrapper } from '../../utils/interface.js';
import { pageModifications } from '../../utils/mutations.js';
import { timelineObject } from '../../utils/react_props.js';
import { timelineSelector } from '../../utils/timeline_id.js';

const hiddenAttribute = 'data-no-recommended-community-carousels-hidden';

Expand All @@ -12,24 +13,32 @@ export const styleElement = buildStyle(`
`);

const carouselSelector = `${keyToCss('listTimelineObject')} ${keyToCss('carouselWrapper')}`;
const masonryCarouselSelector = keyToCss('communityRows');

const hideCommunityCarousels = carousels =>
carousels.forEach(async carousel => {
const { elements } = await timelineObject(carousel);
if (elements.some(({ objectType }) => objectType === 'community_card')) {
const timelineItem = getTimelineItemWrapper(carousel);
if (
timelineItem.previousElementSibling.querySelector(keyToCss('titleObject')) ||
timelineItem.previousElementSibling.dataset.cellId?.startsWith('timelineObject:title')
timelineItem.previousElementSibling?.querySelector(keyToCss('titleObject')) ||
timelineItem.previousElementSibling?.dataset.cellId?.startsWith('timelineObject:title')
) {
timelineItem.toggleAttribute(hiddenAttribute, true);
timelineItem.previousElementSibling.toggleAttribute(hiddenAttribute, true);
} else if (
timelineItem.querySelector(keyToCss('titleObject'))
) {
timelineItem.toggleAttribute(hiddenAttribute, true);
}
}
});

export const main = async function () {
pageModifications.register(carouselSelector, hideCommunityCarousels);
pageModifications.register(
`${timelineSelector} :is(${carouselSelector}, ${masonryCarouselSelector})`,
hideCommunityCarousels,
);
};

export const clean = async function () {
Expand Down