Skip to content

fix(No Recommended): Enable blog/community carousel hiding in masonry views - #2352

Open
marcustyphoon wants to merge 2 commits into
marcustyphoon/no-recommended-masonry-fix-0from
marcustyphoon/no-recommended-masonry-fix-1
Open

marcustyphoon wants to merge 2 commits into
marcustyphoon/no-recommended-masonry-fix-0from
marcustyphoon/no-recommended-masonry-fix-1

Conversation

@marcustyphoon

Copy link
Copy Markdown
Collaborator

Description

In masonry views, recommended blog/tag/community elements between posts are displayed differently and No Recommended fails to hide them. This fixes two of the three.

This currently doesn't include tag carousels since... I can't find one. I wrote "Check out these tags" in the linked issue, though, so obviously they exist. Based on staring at a bunch of minified javascript, I'd believe you if you told me the correct selector for them is or includes keyToCss('tagGrid'), but also if you did not say that. So.

Related/mostly resolves: #2322.

Screenshots

n/a

Testing steps

  • Confirm that the "Hide recommended blogs between posts" and "Hide recommended communities between posts" No Recommended options still works on normal timelines.
  • Confirm that the "Hide recommended blogs between posts" and "Hide recommended communities between posts" No Recommended options work on masonry-view timelines.

@marcustyphoon

Copy link
Copy Markdown
Collaborator Author

I would say I really wasn't sure what decisions to make to make this as robust as possible? Like, should the masonry selector be keyed on keyToCss('masonry') instead of a timeline selector? Should we be checking the title text? I dunno, I don't have a good grasp on this.

@AprilSylph
AprilSylph self-requested a review August 26, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No Recommended: Broken recommended blog/tag/community hiding between posts in masonry views

1 participant