fix(No Recommended): Enable blog/community carousel hiding in masonry views - #2352
Open
marcustyphoon wants to merge 2 commits into
Open
marcustyphoon wants to merge 2 commits into
marcustyphoon wants to merge 2 commits into
Conversation
Collaborator
Author
|
I would say I really wasn't sure what decisions to make to make this as robust as possible? Like, should the masonry selector be keyed on |
AprilSylph
self-requested a review
August 26, 2026 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In masonry views, recommended blog/tag/community elements between posts are displayed differently and No Recommended fails to hide them. This fixes two of the three.
This currently doesn't include tag carousels since... I can't find one. I wrote "Check out these tags" in the linked issue, though, so obviously they exist. Based on staring at a bunch of minified javascript, I'd believe you if you told me the correct selector for them is or includes
keyToCss('tagGrid'), but also if you did not say that. So.Related/mostly resolves: #2322.
Screenshots
n/a
Testing steps