Fix incorrect thruster mapping for jointThrAllocation#1416
Open
Will-Schwend wants to merge 8 commits into
Open
Fix incorrect thruster mapping for jointThrAllocation#1416Will-Schwend wants to merge 8 commits into
Will-Schwend wants to merge 8 commits into
Conversation
Will-Schwend
added a commit
that referenced
this pull request
Jun 11, 2026
Will-Schwend
added a commit
that referenced
this pull request
Jun 11, 2026
Will-Schwend
added a commit
that referenced
this pull request
Jun 11, 2026
c50a163 to
cdc1460
Compare
Will-Schwend
added a commit
that referenced
this pull request
Jun 11, 2026
Will-Schwend
added a commit
that referenced
this pull request
Jun 11, 2026
Will-Schwend
added a commit
that referenced
this pull request
Jun 11, 2026
Will-Schwend
added a commit
that referenced
this pull request
Jun 11, 2026
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cdc1460443
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
schaubh
requested changes
Jun 12, 2026
cdc1460 to
beb6856
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
jointThrAllocationso the spacecraft center of mass (CoM) used in the thruster wrench map is computed from articulated-arm geometry and body mass properties instead of relying on a separate static CoM state input.The main changes are:
THRArmConfigMsgPayloadto include the kinematic and mass-property data needed to represent articulated spacecraft bodiesCoMStatesInMsgfromjointThrAllocation, since it is no longer usedjointThrAllocationto computer_ComB_Bdynamically during the optimization based on the current joint-angle solutionVerification
Changes were validated with updated unit-test coverage and an integrated MuJoCo scenario.
Validation included:
test_jointThrAllocation.py:jointPoseFromThetaandcomputeComFromThetaacross multiple spacecraft configurationsscenarioThrArmControl.py/ MuJoCo FSW setup:Documentation
This PR updates documentation for the revised allocation behavior:
src/fswAlgorithms/effectorInterfaces/jointThrAllocation/jointThrAllocation.rstdocs/source/Support/bskKnownIssues.rstdocs/source/Support/bskReleaseNotesSnippets/1416-JointThrAllocation-Fix.rstFuture work
N/A