Skip to content

[codex] Add Zihao Huang homepage link #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
worstwoof wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[codex] Add Zihao Huang homepage link #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/tests/test_frontend_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,10 @@ def test_overview_places_requested_organizers_after_hero(self) -> None:
"https://zcyyc.github.io/",
"https://nkcs.iops.ai/zhangshenglin/",
"https://marvin233.github.io/",
"https://worstwoof.github.io/",
):
self.assertIn(homepage, html)
self.assertEqual(html.count('aria-label="Homepage link to be announced"'), 4)
self.assertEqual(html.count('aria-label="Homepage link to be announced"'), 3)
self.assertIn('src="assets/overview-icons/organizers.png"', html)
self.assertTrue((ROOT / "assets" / "overview-icons" / "organizers.png").is_file())
self.assertNotIn(".overview-page .overview-organizer-list li + li", css)
Expand Down
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ <h2 id="organizers-title" class="overview-section-heading overview-organizers-he
<li>
<strong>Zihao Huang</strong>
<span class="overview-organizer-affiliation">Nankai University</span>
<span class="overview-organizer-homepage is-placeholder" aria-label="Homepage link to be announced">Homepage <span aria-hidden="true">↗</span></span>
<a class="overview-organizer-homepage" href="https://worstwoof.github.io/" target="_blank" rel="noreferrer">Homepage <span aria-hidden="true">↗</span></a>
</li>
<li>
<strong>An Xu</strong>
Expand Down