feat(generation): 四向八向使用全方向独立合同 - #577
Merged
huyanxius merged 3 commits intoAug 24, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
/review |
This was referenced Aug 24, 2026
xyh202131
force-pushed
the
feat/full-direction-contract
branch
from
August 24, 2026 04:33
c6e3cf1 to
97342fd
Compare
xyh202131
marked this pull request as ready for review
August 24, 2026 05:31
Contributor
There was a problem hiding this comment.
Reviewed the full fixed diff for the direction-generation contract. The backend contract changes are directionally consistent, but two integration paths still allow incomplete or incorrectly published multi-direction assets. The local Python and frontend test runners were unavailable in this environment (pytest/uv missing; vitest not executable).
Additional findings
backend/packages/app/src/windup_app/web/api/character.py:?: [P1] Validate legacy multi-direction assets before publishing: This guard bypassesvalidate_character_directionswheneverdata.version < 2.CharacterStatus.from_character_datacan still classify a legacy v1 payload asPUBLISHED, so create/update accept v1 characters in four- or eight-way projects even though the new validator explicitly rejects those mirror-based assets as incomplete. Remove the version check here and let the validator retain only the intended v1 single-direction compatibility case.
…eat/full-direction-contract # Conflicts: # frontend/src/pages/quick-start/service.test.ts
This was referenced Aug 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容
generationDirections验证
git diff --check通过Refs #544
Refs #222