Skip to content

fix(workflow): 新增动作复用已有 WorkflowRun - #591

Merged
huyanxius merged 2 commits into
1024XEngineer:mainfrom
xyh202131:fix/reuse-existing-workflow-run
Aug 24, 2026
Merged

huyanxius merged 2 commits into
1024XEngineer:mainfrom
xyh202131:fix/reuse-existing-workflow-run

Conversation

@xyh202131

@xyh202131 xyh202131 commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

变更内容

  • 角色详情中的“新增动作”直接进入角色原有 WorkflowRun。
  • Quick Start 在原 Run 内追加动作分支,不再复制角色母版或创建独立 Run。
  • Workflow Editor 直接打开角色已有 Run,复用现有的动作节点创建能力。
  • 删除只用于创建独立动作 Run 的重复模块和专用入口。
  • 历史动作分支失败时仍可新增独立动作;仅在当前仍有运行节点时阻止重复提交。

验证

  • 定向测试:Quick Start 页面 79 项通过
  • 全量前端测试:70 个测试文件、1007 项测试全部通过
  • 全量覆盖率:语句 92.90%、分支 87.58%、函数 95.96%、行 95.80%
  • 类型检查、lint、生产构建通过
  • GitHub Frontend、Backend、Vercel 检查通过

关联

@vercel

vercel Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
windup Ready Ready Preview Aug 24, 2026 6:00am

@github-actions

Copy link
Copy Markdown

⚠️ @xyh202131,此 PR 尚未关联 issue。请在 PR 描述中使用 Closes #123 等关闭关键字;更新描述后,此提醒将自动标记为已解决。

@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.08696% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
frontend/src/pages/quick-start/service.ts 57.14% 3 Missing and 3 partials ⚠️
frontend/src/pages/quick-start/index.tsx 86.20% 1 Missing and 3 partials ⚠️
frontend/src/pages/character-detail/index.tsx 66.66% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

审查了角色详情入口、Quick Start 的既有 Run 追加动作流程,以及 WorkflowRun/角色资产同步契约。发现一个会阻断既有角色继续添加动作的状态回归;其余改动路径未发现达到报告阈值的问题。由于当前工作区没有可执行的 node_modules/.bin,定向测试和类型检查无法运行。

Comment thread frontend/src/pages/quick-start/index.tsx Outdated

@huyanxius huyanxius left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huyanxius
huyanxius merged commit c9dab16 into 1024XEngineer:main Aug 24, 2026
9 checks passed

This branch was successfully deployed

1 active deployment
Preview — 990ed61b Deployed Aug 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants