Repository navigation
Use the selected provider for drift ordering - #121
Conversation
0xfauzi
left a comment
There was a problem hiding this comment.
One blocking item against the scope of #118 (see the inline comment). The provider selection, the --provider override, and the tests for keys, failures and cache are correct. I ran the full suite on this head. The only failures are 4 tests that also fail on the base commit in my environment, because of git commit signing and a timing limit.
Generated by Claude Code
0xfauzi
left a comment
There was a problem hiding this comment.
Approved at b93ee36. The blocking item is fixed. providers.require_drift uses the same check as triage, and it runs before the provider is created. With OpenAI selected, the command sends no data to either provider and gives the cause in text and in drift_order.reason. The tests cover this. The reference, the trust and security page and the CHANGELOG agree with the code.
I ran the full suite on this head and on main 02a496b. Both have the same 3 failures, which come from git commit signing in my environment. All other tests pass. mypy --strict, pre-commit, systemap check and judgement pass. All CI checks pass, and the branch merges cleanly with main.
Generated by Claude Code
judgement --order-by-driftpreviously sent source text and map claims to Jev even when[decisions] provider = "openai"selected OpenAI.Text and JSON reports now use the shared provider selector.
--provideroverrides the configuration. Drift questions require a measured result for the selected provider. OpenAI has no measured drift result. With OpenAI selected, the command sends no request and gives the cause in text and JSON. It does not create an OpenAI transport or fall back to Jev. A missing Jev key or a failed Jev request gives no score. Keys alone do not cause requests. Drift ordering still changes only the order of stale review lines, with the same findings and exit codes.Closes #118.
The change updates command help, the reference, the trust and security page, and the generated site. The system map records the provider rule and the current source references. The CLI flow claims retain their direction and artifacts.
Validation:
uv run pytest -q --tb=short: 2,043 passed, 2 skipped.uv run pre-commit run --all-filesanduv run mypy src --strictpass.uv run --group site python site/build.py --checkpasses.uv run systemap refresh,check, andjudgementpass. All 161 modules are mapped, and all 16 component source reviews are current.The required
~/.claude/WRITING.mdis absent, and the official ASD-STE100 reference was unavailable. The available project language policy was used. No ASD-STE100 acceptance result is claimed.