Repository navigation
Publish PyPy wheels in the c-code template - #462
Conversation
Coverage Report for CI Build 40292656207Coverage increased (+0.6%) to 21.167%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
dataflake
left a comment
There was a problem hiding this comment.
I can't really say much about anything related to Pypy. Never used it, don't see myself using it and wondering if anyone at all uses ZF packages with Pypy.
With that said, in other places I have seen you switch Pypy to 3.12 but here it's 3.11 again. Is that intentional?
I think @jamadden is using it. Yes, it sometimes feels like a burden but other times it also helps to find problems because it is a different interpreter. Zope 5 cannot use it because RestrictedPython cannot be made compatible with it (because of a design decision in PyPy which prevents setting a restricted set of builtins), so it is more of a niche usage.
Yes, this is intentional, PyPy-3.12 is still a beta version and e.g. zope.password breaks against it: zopefoundation/zope.password#32 (It only ran there because zope.password was not up to date with zope.meta and thus did use a random PyPy version.) That's why: lets keep 3.11 as the version to be tested against. (I am loosely following the PyPy news, so I think I'll get informed when it is time to switch.) |
dataflake
left a comment
There was a problem hiding this comment.
Thank you for the detailed explanation!
Build, test and publish PyPy wheels for macOS (arm64), Windows (x64) and manylinux (x86_64, i686, aarch64) for packages with
with-pypy = true.Verified with persistent: zopefoundation/persistent#241 (CI run produced PyPy wheels on all platforms and the PyPy test jobs passed).
Workaround for pypa/setuptools#5367 which shows up in our GitHub Actions runs.