RFC: Add enum ReprEndianness constant to PrimeField trait#4
Open
tarcieri wants to merge 1 commit into
Open
Conversation
tarcieri
force-pushed
the
ff-prime-field-repr-endianness
branch
from
48fb332 to
8f44c47
Compare
tarcieri
commented
Jun 4, 2026
| Downstream consumers of `PrimeField::Repr`, including the `group` crate, need to instead handle it | ||
| in an endian-aware manner. | ||
|
|
||
| # Guide-level explanation |
Author
There was a problem hiding this comment.
I may have misunderstood the purpose of this section versus "Reference-level explanation" and could potentially swap them?
This was referenced Jun 9, 2026
tarcieri
commented
Jun 12, 2026
Comment on lines
+36
to
+40
| pub enum ReprEndianness { | ||
| Big, | ||
| #[default] | ||
| Little, | ||
| } |
Author
There was a problem hiding this comment.
I chose this name based on ff_derive, but I think a pub enum ByteOrder ala the primefield crate might be a little more reusable
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jun 16, 2026
Adds a trait for specifying the endianness of the serialized representation of a field element as a stopgap until zkcrypto/rfcs#4 is accepted. This uses the `ByteOrder` enum and replaces the previous `FIELD_REPR_IS_BE` flag on `PrimeCurveParams`. It also means `Radix16Decomposition` now "Just Works" and doesn't need an endianness parameter passed to `new`. The `primefield::monty_field_element!` macro now writes impls for this trait, sourcing the endianness information from the `MontyFieldParams`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to provide a solution to zkcrypto/group#78.
Rendered