fix(window-tabs-panes): render group header for every multi-pane vertical tab - #318
Open
TranscriptionFactory wants to merge 1 commit into
Open
Conversation
…ical tab (warpdotdev#9098) (warpdotdev#10738) (cherry picked from commit b193c5e)
jwp2987
pushed a commit
to jwp2987/phosphor
that referenced
this pull request
Jul 29, 2026
In Panes display granularity, the vertical tab bar only rendered a tab-group header when the tab had a user-set custom title or was being renamed inline. Multi-pane tabs with auto-generated names (the AI/CLI session naming flow) therefore showed no tab-level identifier at all -- only the first row's pane title was visible, making every such tab look identical in the sidebar. Extracts the header gate into a testable should_show_tab_group_header helper and adds a third trigger: any tab with more than one visible pane now renders its group header. Single-pane groups without a custom title still omit it, since the lone row already shows the same title. Ports upstream zerx-lab#318, fixes warpdotdev#9098. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
This PR has had no activity for 30 days and is being marked as stale. It will be automatically closed in 7 days if no further updates are made. 本 PR 已 30 天无活动,标记为 stale。如 7 天内仍无更新将自动关闭。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
Panesdisplay granularity, the vertical tab bar only rendered a tab-group header when the tab had a user-set custom title or was being renamed inline. Multi-pane tabs with auto-generated names therefore showed no tab-level identifier at all — only the first row's pane title was visible, making every such tab look identical in the sidebar (upstream report: warpdotdev#9098).This extracts the header gate into a testable
should_show_tab_group_headerhelper and adds a third trigger: any tab with more than one visible pane now renders its group header. Single-pane groups without a custom title still omit the header, since the lone row already shows the same title and rendering it twice would duplicate the text.Changes
app/src/workspace/view/vertical_tabs.rs: newshould_show_tab_group_header(has_custom_title, is_being_renamed, visible_pane_count)helper; header now renders for multi-pane groups.app/src/workspace/view/vertical_tabs_tests.rs: 5 regression tests covering the gate (custom title, inline rename, multi-pane without title, single-pane suppression, and the multi-tab scenario from the original report).Testing
cargo test -p warp vertical_tabs— all 5 new tests pass; the 9 pre-existing failures in that filter reproduce identically on cleanmain(test-harness singleton/i18n setup issues, unrelated to this change).