Skip to content

[WIP] header explicitly add content - #147

Draft
zeratax wants to merge 1 commit into
masterfrom
header-constexpr
Draft

[WIP] header explicitly add content#147
zeratax wants to merge 1 commit into
masterfrom
header-constexpr

Conversation

@zeratax

@zeratax zeratax commented Mar 28, 2020

Copy link
Copy Markdown
Owner

!fixes #70
!fixes #72

really wish I knew how to use constexpr like at all: https://github.com/ZerataX/yacx/blob/447ddb3e8392668b9a3bd29cbba2d33316ba7b6e/include/yacx/Headers.hpp#L21
if this was constexpr it would make it really clear that using e.g. load is a bad idea, but I have no clue how. If no one knows, just move this to a new issue

probably a neater way to check if both sides of the pair are castable to string
https://github.com/ZerataX/yacx/blob/447ddb3e8392668b9a3bd29cbba2d33316ba7b6e/include/yacx/Headers.hpp#L37-L43

maybe even by using https://github.com/ZerataX/yacx/blob/master/include/yacx/util.hpp#L23-L29

Still can't test anything :/

@zeratax zeratax added the bug Something isn't working label Mar 28, 2020
@zeratax zeratax added this to the v1 basic executor milestone Mar 28, 2020
@LukasSiefke

Copy link
Copy Markdown
Collaborator

So ein biscchen frage ich mich auch, ob es soo viel Sinn macht den Headercontent als String zu übergeben, weil man den dann im Prinzip auch direkt in Source reinklatschen könnte. Aber ich glaube bei komplexeren Kernels kann es vielleicht doch sinnvoll sein.
Wobei man im Allgemeinen auch gut die --include-path=dir-Option von nvrtc nutzen kann, sodass nvrtc in dem angegebenen Pfad nach den Headern sucht...

@zeratax

zeratax commented Mar 28, 2020

Copy link
Copy Markdown
Owner Author

Wobei man im Allgemeinen auch gut die --include-path=dir-Option von nvrtc nutzen kann, sodass nvrtc in dem angegebenen Pfad nach den Headern sucht...

Ja also das hier macht halt wirklich nur Sinn, wenn man ne binary am ende haben will, wo dann beim enduser die header nicht mehr auf der festplatte sind sondern nur noch in der binary

@zeratax
zeratax marked this pull request as draft May 3, 2020 21:51
@zeratax zeratax self-assigned this May 3, 2020
@zeratax
zeratax requested a review from LukasSiefke May 3, 2020 21:51
@zeratax zeratax changed the title header explicitly add content [WIP] header explicitly add content May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

absolute path constant Headers-Klasse

2 participants